memory leak in ustring

[DougRogers]

ustring cpp

    ustring::TableRep* make_rep(string_view str, size_t hash)
    {
        char* repmem = pool_alloc(sizeof(ustring::TableRep) + str.length() + 1);
        return new (repmem) ustring::TableRep(str, hash);
    }

        ustring::TableRep* rep = make_rep(str, hash);
        entries[pos]           = rep;

all entries are not freed. The only call I see is

free(entries);

[jreichel-nvidia]

This is probably by design (see ~TableRepMap() and the documentation about ustring).

For me this is causing quite some problems when using tools like valgrind. Writing suppressions for these issues is not trivial (several call stacks, depends on toolchain/compiler options/etc.) and works only if debug info is available.

Would it be possible to change the behavior such that all memory is properly released at the end? Possibly opt-in via an option if not by default?

[lgritz]

I have no objection to that; let me take a look at what it involves.

[lgritz]

Proposed fix: #5193