From 6edbd6fc6f36bd476430b24896cf5c4d4dbda38d Mon Sep 17 00:00:00 2001 From: Norbert Hartl Date: Sat, 1 Aug 2026 15:50:53 +0200 Subject: [PATCH 1/2] Declare OpenAPI-REST-Tests' actual dependency on OpenAPI-Core-Tests OpenAPISpecCall (in OpenAPI-REST-Tests) references PetsAPI, which is defined in OpenAPI-Core-Tests - but the baseline only declared OpenAPI-REST as a requirement. This worked only by accident because the default Tests group happens to load all three Tests packages together; loading OpenAPI-REST-Tests on its own would fail to resolve PetsAPI. Co-Authored-By: Claude Sonnet 5 --- source/BaselineOfOpenAPI/BaselineOfOpenAPI.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/BaselineOfOpenAPI/BaselineOfOpenAPI.class.st b/source/BaselineOfOpenAPI/BaselineOfOpenAPI.class.st index 6a033d1..9bb09e0 100644 --- a/source/BaselineOfOpenAPI/BaselineOfOpenAPI.class.st +++ b/source/BaselineOfOpenAPI/BaselineOfOpenAPI.class.st @@ -15,7 +15,7 @@ BaselineOfOpenAPI >> baseline: spec [ package: 'OpenAPI-Core' with: [ spec requires: #('JSONSchema Core' 'NeoJSON'). ]; package: 'OpenAPI-Core-Tests' with: [ spec requires: #('OpenAPI-Core' 'JSONSchema Tests'). ]; package: 'OpenAPI-REST' with: [ spec requires: #('OpenAPI-Core' 'ZincHTTPComponents') ]; - package: 'OpenAPI-REST-Tests' with: [ spec requires: #('OpenAPI-REST') ]; + package: 'OpenAPI-REST-Tests' with: [ spec requires: #('OpenAPI-REST' 'OpenAPI-Core-Tests') ]; package: 'OpenAPI-Client' with: [ spec requires: #('OpenAPI-Core') ]; package: 'OpenAPI-Client-Tests' with: [ spec requires: #('OpenAPI-Client') ]. spec From 65845e109875370f8147e5f55c2aa22a0704d4af Mon Sep 17 00:00:00 2001 From: Norbert Hartl Date: Sat, 1 Aug 2026 15:50:53 +0200 Subject: [PATCH 2/2] Remove dead code: OAResponse>>convert:contentType: and friends convert:contentType:/convertApplicationJson:/convertTextPlain: were never called from anywhere in the codebase. The actual response- parsing path is OAResponse>>handleResponse: (used by OpenApiClient>>handleResponse:), which dispatches to OAMediaTypeObject>>handleResponse: instead - a separate, unrelated method despite the similar name. Co-Authored-By: Claude Sonnet 5 --- source/OpenAPI-Core/OAResponse.class.st | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/source/OpenAPI-Core/OAResponse.class.st b/source/OpenAPI-Core/OAResponse.class.st index 02921da..6ce9929 100644 --- a/source/OpenAPI-Core/OAResponse.class.st +++ b/source/OpenAPI-Core/OAResponse.class.st @@ -60,27 +60,6 @@ OAResponse >> contentAtType: aString put: aMediaTypeObject [ content at: aString put: aMediaTypeObject ] -{ #category : 'as yet unclassified' } -OAResponse >> convert: aString contentType: aMimeType [ - | methodName | - methodName := 'convert', aMimeType main capitalized, aMimeType sub capitalized. - ^ self - perform: methodName asSymbol asMutator - with: aString -] - -{ #category : 'as yet unclassified' } -OAResponse >> convertApplicationJson: aString [ - ^ (NeoJSONReader on: aString readStream) - mapClass: NeoJSONObject; - next -] - -{ #category : 'as yet unclassified' } -OAResponse >> convertTextPlain: aString [ - ^ aString -] - { #category : 'accessing' } OAResponse >> description [ ^ description.