Merge pull request #37 from AthennaIO/develop

fix(handlers): remove logger enabled validation on errors

Author: jlenon7

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@athenna/queue",
-  "version": "5.20.0",
+  "version": "5.21.0",
   "description": "The Athenna queue handler.",
   "license": "MIT",
   "author": "João Lenon <lenon@athenna.io>",

package.json

@@ -38,25 +38,23 @@ export class AwsSqsDriverExceptionHandler extends ExceptionHandler {
     // @ts-ignore
     await super.handle({ job, error, driver, stopHeartbeat, requeueJitterMs })
 
-    if (Config.is('worker.logger.enabled', true)) {
-      if (Config.is('worker.logger.prettifyException')) {
-        Log.channelOrVanilla('exception').error(
-          await error.toAthennaException().prettify()
-        )
-      } else {
-        Log.channelOrVanilla('exception').error({
-          msg: `failed to process job: ${error.message}`,
-          queue: driver.queueName,
-          deadletter: driver.deadletter,
-          name: error.name,
-          code: error.code,
-          help: error.help,
-          details: error.details,
-          metadata: error.metadata,
-          stack: error.stack,
-          job
-        })
-      }
+    if (Config.is('worker.logger.prettifyException')) {
+      Log.channelOrVanilla('exception').error(
+        await error.toAthennaException().prettify()
+      )
+    } else {
+      Log.channelOrVanilla('exception').error({
+        msg: `failed to process job: ${error.message}`,
+        queue: driver.queueName,
+        deadletter: driver.deadletter,
+        name: error.name,
+        code: error.code,
+        help: error.help,
+        details: error.details,
+        metadata: error.metadata,
+        stack: error.stack,
+        job
+      })
     }
 
     if (shouldRetry) {

src/handlers/AwsSqsDriverExceptionHandler.ts

@@ -30,25 +30,23 @@ export class DatabaseDriverExceptionHandler extends ExceptionHandler {
     // @ts-ignore
     await super.handle({ job, error, driver, requeueJitterMs })
 
-    if (Config.is('worker.logger.enabled', true)) {
-      if (Config.is('worker.logger.prettifyException')) {
-        Log.channelOrVanilla('exception').error(
-          await error.toAthennaException().prettify()
-        )
-      } else {
-        Log.channelOrVanilla('exception').error({
-          msg: `failed to process job: ${error.message}`,
-          queue: driver.queueName,
-          deadletter: driver.deadletter,
-          name: error.name,
-          code: error.code,
-          help: error.help,
-          details: error.details,
-          metadata: error.metadata,
-          stack: error.stack,
-          job
-        })
-      }
+    if (Config.is('worker.logger.prettifyException')) {
+      Log.channelOrVanilla('exception').error(
+        await error.toAthennaException().prettify()
+      )
+    } else {
+      Log.channelOrVanilla('exception').error({
+        msg: `failed to process job: ${error.message}`,
+        queue: driver.queueName,
+        deadletter: driver.deadletter,
+        name: error.name,
+        code: error.code,
+        help: error.help,
+        details: error.details,
+        metadata: error.metadata,
+        stack: error.stack,
+        job
+      })
     }
 
     if (!shouldRetry) {

src/handlers/DatabaseDriverExceptionHandler.ts

@@ -32,25 +32,23 @@ export class MemoryDriverExceptionHandler extends ExceptionHandler {
 
     job.reservedUntil = null
 
-    if (Config.is('worker.logger.enabled', true)) {
-      if (Config.is('worker.logger.prettifyException')) {
-        Log.channelOrVanilla('exception').error(
-          await error.toAthennaException().prettify()
-        )
-      } else {
-        Log.channelOrVanilla('exception').error({
-          msg: `failed to process job: ${error.message}`,
-          queue: driver.queueName,
-          deadletter: driver.deadletter,
-          name: error.name,
-          code: error.code,
-          help: error.help,
-          details: error.details,
-          metadata: error.metadata,
-          stack: error.stack,
-          job
-        })
-      }
+    if (Config.is('worker.logger.prettifyException')) {
+      Log.channelOrVanilla('exception').error(
+        await error.toAthennaException().prettify()
+      )
+    } else {
+      Log.channelOrVanilla('exception').error({
+        msg: `failed to process job: ${error.message}`,
+        queue: driver.queueName,
+        deadletter: driver.deadletter,
+        name: error.name,
+        code: error.code,
+        help: error.help,
+        details: error.details,
+        metadata: error.metadata,
+        stack: error.stack,
+        job
+      })
     }
 
     if (shouldRetry) {