DefaultExpansionsBuilder does not support dictionaries

[amorelIM]

Hi @BlaiseD,

I tried to upgrade from version 5.0.2 to 7.0.1, and I have an issue since the DefaultExpansionsBuilder was added. I have the following entities :

// EFCore entity
class Entity
{
  public Guid Id {get; set;}

  public string ExtraData {get; set;} // JSON stored as string
}

// OData entity
class EntityDto
{
  public Guid Id {get; set;}

  public IDictionary<string, string> ExtraData {get; set;} = new Dictionary<string, string>(); // It's a dictionary of strings since we don't know what's stored in the JSON.
}

But now at runtime a get the following exception because the dictionary contains 2 generics.

System.ArgumentException: type
   at LogicBuilder.Expressions.Utils.TypeExtensions.GetUnderlyingElementType(Type type)
   at AutoMapper.AspNet.OData.Expansions.DefaultExpansionsBuilder.Build(List`1 memberSelectors, ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.DefaultExpansionsBuilder.Build(ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.GetSelectedSelectors(ParameterExpression param, Expression parentBody, List`1 selects)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.AddSelectors(List`1 memberSelectors, List`1 selects, ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.<>c__DisplayClass2_0`1.<BuildExplicitExpansions>g__GetAllExpansions|0(List`1 memberSelectors)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.BuildExplicitExpansions[TSource](IEnumerable`1 includes, List`1 selects)
   at AutoMapper.AspNet.OData.QueryableExtensions.GetQueryable[TModel,TData](IQueryable`1 query, IMapper mapper, ODataQueryOptions`1 options, QuerySettings querySettings, Expression`1 filter)
   at AutoMapper.AspNet.OData.QueryableExtensions.GetQueryAsync[TModel,TData](IQueryable`1 query, IMapper mapper, ODataQueryOptions`1 options, QuerySettings querySettings)

I don't mind doing the correction, but I would need some guidance.

[amorelIM]

I tried to add a test in ExpansionTests.cs using VinylRecordModel, it contains a dictionary property, and even there it throws an exception.

[Fact]
public async Task Test()
{
    string query = "/vinylrecordmodel";
    void Test(ICollection<VinylRecordModel> collection)
    {
        Assert.True(collection.Count > 0);
    }
}

[BlaiseD]

I would first identify the previous behavior i.e. why did it work before? Also the LogicBuilder.Expression.Utls library does handle dictionaries differently than other enumerables in some cases e.g. here.

You'll want to test your use case against a similar fix.

[gmejias-RMS]

Also facing same issue. We are using Dictionary<string, object> and stopped working when upgrading from 5.0.2 to 7.0.1. Not sure but could be related to #229 and BpsLogicBuilder/LogicBuilder.DataComponents#55

[alexmo16]

FYI @gmejias-RMS #240

[gmejias-RMS]

Hello @alexmo16 @BlaiseD Testing new released version 7.0.2, now I'm facing a different exception. I'm still using Dictionary<string, object> Thanks in advance!

System.ArgumentException: type
   at AutoMapper.AspNet.OData.TypeExtensions.GetUnderlyingElementType(Type type)
   at AutoMapper.AspNet.OData.Expansions.DefaultExpansionsBuilder.Build(List`1 memberSelectors, ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.DefaultExpansionsBuilder.Build(ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.GetSelectedSelectors(ParameterExpression param, Expression parentBody, List`1 selects)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.AddSelectors(List`1 memberSelectors, List`1 selects, ParameterExpression param, Expression parentBody)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.<>c__DisplayClass2_0`1.<BuildExplicitExpansions>g__GetAllExpansions|0(List`1 memberSelectors)
   at AutoMapper.AspNet.OData.Expansions.ExpansionsHelper.BuildExplicitExpansions[TSource](IEnumerable`1 includes, List`1 selects)
   at AutoMapper.AspNet.OData.QueryableExtensions.GetQueryable[TModel,TData](IQueryable`1 query, IMapper mapper, ODataQueryOptions`1 options, QuerySettings querySettings, Expression`1 filter)
   at AutoMapper.AspNet.OData.QueryableExtensions.GetQuery[TModel,TData](IQueryable`1 query, IMapper mapper, ODataQueryOptions`1 options, QuerySettings querySettings)

[amorelIM]

@gmejias-RMS as a workaround, try using IDictionary<string, object> instead of Dictionary<string, object> for the property type.

We're using IDictionary and I had no problem when integrating 7.0.2

I guess a fix could be made for Dictionary.

[gmejias-RMS]

That worked, thanks for tip!

[amorelIM]

My problem is now fixed with release 7.0.2

[BlaiseD]

@gmejias-RMS as a workaround, try using IDictionary<string, object> instead of Dictionary<string, object> for the property type.

We're using IDictionary and I had no problem when integrating 7.0.2

I guess a fix could be made for Dictionary.

Yep - another check to support subclasses of Dictionary<K, V> will work. - maybe

            else if (type.GetInterface(typeof(System.Collections.IDictionary).FullName ?? "") != null && genericArguments.Length == 2)
                return typeof(KeyValuePair<,>).MakeGenericType(genericArguments[0], genericArguments[1]);