Port demos to ES6, add pure flavors, and remove all UMD demos#759
Draft
RaananW wants to merge 3 commits into
Draft
Port demos to ES6, add pure flavors, and remove all UMD demos#759RaananW wants to merge 3 commits into
RaananW wants to merge 3 commits into
Conversation
Migrate the legacy UMD demos to ES6 `@babylonjs/*` packages, each in both
the compiled (`src/compiledDemos`) and tree-shaken pure
(`src/pureCompiledDemos`) flavors, and remove the legacy UMD code from the
website per AGENTS.md ("no UMD demos").
- Add ES6 compiled + pure versions of the ported demos, wired through the
shared demoRunner and registered in both manifests.
- Strip leftover legacy UMD code (*.js and legacy index.html) from already
ported static/Demos folders; keep all asset files (textures, .babylon,
.hdr, .fx, screenshots). Fully ported demos with no assets are removed.
- Register RegisterEnginesExtensionsEngineRawTexture in the Simplification
pure scene so the Dude scene textures load under the pure barrel.
- Smoke harness, shared demoRunners, and AGENTS.md contributor guide updates.
Validation: full build, compiled smoke (85/86, Flat2009 render-check
disabled for headless video), and pure smoke (85) all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the legacy UMD demos to ES6
@babylonjs/*packages and removes all UMD demos from the website, per the contributor rule inAGENTS.md("no UMD demos"). Every ported demo exists in both flavors:src/compiledDemos/<Slug>/) — deep@babylonjs/core/...named imports + side-effect imports.src/pureCompiledDemos/<Slug>/) — tree-shaken@babylonjs/core/purebarrel + explicitRegister*()calls.Changes
demoRunnerand registered in bothmanifest.jsonfiles.*.jsand legacyindex.html) from already-portedstatic/Demos/<Slug>folders. All asset files (textures,.babylon,.hdr,.fx, screenshots) are preserved; fully-ported demos that contained only code are removed entirely.RegisterEnginesExtensionsEngineRawTexture()so the Dude scene textures load under the pure barrel.demoRunner(compiled + pure), andAGENTS.mdcontributor-guide updates.Validation
npm run build— succeeds (86 compiled demos).npm run demos:smoke— 85/86 pass (Flat2009 hasrenderCheck.disabledbecause its VideoTexture can't decode under headless swiftshader; works in real browsers).npm run demos:pure:smoke— 85 pass.npm run demos:format:write— clean.Not ported (deferred / unportable)
.fxshaders / multi-canvas: Planet, Views