Reorganize parts libraries#492
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the edg parts ecosystem into clearer subpackages (notably parts/ by domain, plus new vendor_parts/ and circuits/) and updates example reference netlists accordingly, as part of the longer-term split described in #479.
Changes:
- Introduces
edg/vendor_parts/(incl.jlc/andjlcparts/) andedg/circuits/packages and re-exports them fromedg/__init__.py/edg/BoardTop.py. - Restructures
edg/parts/into domain subpackages (analog, connector, debug, display, human_interface, interface, logic, microcontroller, power, sensor) and updates many imports. - Updates many
examples/*.net.ref“Sheetfile” paths to match the new module layout; removes several one-off example renaming scripts and adds a repo-wide netlist ref updater.
Reviewed changes
Copilot reviewed 243 out of 289 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/UsbUart/UsbUart.net.ref | Update Sheetfile module paths for moved parts. |
| examples/UsbKey/UsbKey.net.ref | Update Sheetfile module paths for moved parts. |
| examples/update_reference_netlists.py | Add helper script to refresh .net.ref files from generated .net. |
| examples/TestBlinkyWithSchematicImport/TestBlinkyWithSchematicImport.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyWithModeledSchematicImport/TestBlinkyWithModeledSchematicImport.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyWithLibraryExport/TestBlinkyWithLibraryExport.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyWithLibrary/TestBlinkyWithLibrary.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyPacked/TestBlinkyPacked.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyMicro/TestBlinkyMicro.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyImplicit/TestBlinkyImplicit.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyExpanded/TestBlinkyExpanded.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyComplete/TestBlinkyComplete.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyBasicBattery/TestBlinkyBasicBattery.net.ref | Update Sheetfile module paths for moved parts. |
| examples/TestBlinkyArray/TestBlinkyArray.net.ref | Update Sheetfile module paths for moved parts. |
| examples/Simon/Simon.net.ref | Update Sheetfile module paths for moved parts. |
| examples/SevenSegment/resources/rename_parts.py | Remove example-specific PCB refdes renaming script. |
| examples/RobotOwl/resources/rename_parts.py | Remove example-specific PCB refdes renaming script. |
| examples/ProtectedCharger/ProtectedCharger.net.ref | Update Sheetfile module paths (incl. circuit move to edg.circuits). |
| examples/JacdacKeyswitch/JacdacKeyswitch.net.ref | Update Sheetfile module paths for moved parts. |
| examples/IotRollerBlinds/IotRollerBlinds.net.ref | Update Sheetfile module paths for moved parts. |
| examples/IotKnob/resources/rename_parts.py | Remove example-specific PCB refdes renaming script. |
| examples/IotFan/resources/rename_parts.py | Remove example-specific PCB refdes renaming script. |
| examples/EspProgrammer/EspProgrammer.net.ref | Update Sheetfile module paths for moved parts. |
| examples/CanAdapter/CanAdapter.net.ref | Update Sheetfile module paths for moved parts. |
| examples/BasicKeyboard/BasicKeyboard.net.ref | Update Sheetfile module paths (SwitchMatrix now in edg.circuits). |
| edg/vendor_parts/TactileSwitches.py | Add vendor-part tactile/mechanical switch footprints. |
| edg/vendor_parts/py.typed | Mark vendor_parts as typed package. |
| edg/vendor_parts/Leds.py | Update JLC import path under new vendor_parts.jlc package. |
| edg/vendor_parts/jlcparts/py.typed | Mark vendor_parts.jlcparts as typed package. |
| edg/vendor_parts/jlcparts/JlcPartsResistorSmd.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsPptcFuse.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsMlcc.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsLed.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsInductor.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsFet.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsFerriteBead.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsElectrolyticCapacitor.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsDiode.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsBoardTop.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsBjt.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/JlcPartsBase.py | Update imports to new package structure. |
| edg/vendor_parts/jlcparts/init.py | Export jlcparts selectors/refinements. |
| edg/vendor_parts/jlc/test_kicad_import_jlc.py | Fix package-relative imports for JLC KiCad import test. |
| edg/vendor_parts/jlc/test_JlcResistor.py | Add unit test for JLC resistor selection/fields. |
| edg/vendor_parts/jlc/test_JlcCapacitor.py | Add unit tests for JLC capacitor selection/refinements. |
| edg/vendor_parts/jlc/test_inductor.py | Add unit test for JLC inductor selection. |
| edg/vendor_parts/jlc/resources/jlcprune.py | Add pruning script for JLC parts CSV. |
| edg/vendor_parts/jlc/resources/init.py | Package marker for JLC resources. |
| edg/vendor_parts/jlc/py.typed | Mark vendor_parts.jlc as typed package. |
| edg/vendor_parts/jlc/PriceGetter.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcSwitches.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcResistorArray.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcResistor.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcPptcFuse.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcPart.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcOscillator.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcLed.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcInductor.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcFet.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcFerriteBead.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcElectrolyticCapacitor.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcDiode.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcCrystal.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcCapacitor.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcBlackbox.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcBjt.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/JlcAntenna.py | Adjust imports for new package structure. |
| edg/vendor_parts/jlc/.gitignore | Update ignore patterns for vendor JLC artifacts. |
| edg/vendor_parts/jlc/init.py | Export JLC vendor part classes under new namespace. |
| edg/vendor_parts/Fuseholder_Nano2.py | Update JLC import path under new vendor package. |
| edg/vendor_parts/CeramicResonator_Cstne.py | Update JLC import path under new vendor package. |
| edg/vendor_parts/init.py | Introduce vendor_parts package exports. |
| edg/parts/sensor/Temp_TexasInstruments.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Temp_Shtc3.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Rtc_Pcf2129.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/py.typed | Mark parts.sensor as typed package. |
| edg/parts/sensor/MagSwitch_Ah1806.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Mag_Qmc5883l.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Mag_A1304.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/LightSensor_Bh1750.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/LightSensor_As7341.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Imu_Lsm6dsv16x.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Imu_Lsm6ds3trc.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/FlirLepton.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/EnvironmentalSensor_Bme680.py | Update imports for new parts.sensor package structure. |
| edg/parts/sensor/Distance_Vl53l0x.py | Update imports + move header connector import to parts.connector. |
| edg/parts/sensor/Camera_Ov2640_Fpc24.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/sensor/init.py | Add sensor subpackage exports + deprecated compatibility shims. |
| edg/parts/resources/supplemental_price.csv | Remove supplemental pricing CSV resource. |
| edg/parts/power/Ref30xx.py | Update imports for new parts.power package structure. |
| edg/parts/power/py.typed | Mark parts.power as typed package. |
| edg/parts/power/motor/StepperDriver_A4988.py | Update imports for new parts.power.motor structure. |
| edg/parts/power/motor/py.typed | Mark parts.power.motor as typed package. |
| edg/parts/power/motor/MotorDriver_L293dd.py | Update imports for new parts.power.motor structure. |
| edg/parts/power/motor/MotorDriver_Drv8870.py | Update imports for new parts.power.motor structure. |
| edg/parts/power/motor/MotorDriver_Drv8833.py | Update imports for new parts.power.motor structure. |
| edg/parts/power/motor/Bldc_Drv8313.py | Update imports for new parts.power.motor structure. |
| edg/parts/power/motor/init.py | Export motor-driver parts. |
| edg/parts/power/LedDriver_Tps92200.py | Update imports for new parts.power package structure. |
| edg/parts/power/LedDriver_Al8861.py | Update imports for new parts.power package structure. |
| edg/parts/power/gate_driver/Ucc27282.py | Update imports for new parts.power.gate_driver structure. |
| edg/parts/power/gate_driver/py.typed | Mark parts.power.gate_driver as typed package. |
| edg/parts/power/gate_driver/Ncp3420.py | Update imports for new parts.power.gate_driver structure. |
| edg/parts/power/gate_driver/Ir2301.py | Update imports for new parts.power.gate_driver structure. |
| edg/parts/power/gate_driver/init.py | Export gate-driver parts. |
| edg/parts/power/FuelGauge_Max17048.py | Update imports for new parts.power package structure. |
| edg/parts/power/converter/Torex_Boost.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/TexasInstruments_SwitchedCap.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/TexasInstruments_Buck.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/TexasInstruments_Boost.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/py.typed | Mark parts.power.converter as typed package. |
| edg/parts/power/converter/Mp2722.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/LinearRegulators.py | Update imports and typing for new parts.power.converter structure. |
| edg/parts/power/converter/DiodesInc_Boost.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/CustomBuckBoost.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/CustomBuck.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/Ap3418.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/AnalogDevices_Boost.py | Update imports for new parts.power.converter structure. |
| edg/parts/power/converter/init.py | Export power converter parts. |
| edg/parts/power/BatteryProtector_S8261A.py | Update imports for new parts.power package structure. |
| edg/parts/power/BatteryCharger_Mcp73831.py | Update imports for new parts.power package structure. |
| edg/parts/power/Batteries.py | Update imports for new parts.power package structure. |
| edg/parts/power/init.py | Export power subpackages/parts. |
| edg/parts/microcontroller/Stm32l432.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Stm32g431.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Stm32g031.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Stm32f303.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Stm32f103.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Rp2040.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/py.typed | Mark parts.microcontroller as typed package. |
| edg/parts/microcontroller/nRF52840.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Lpc1549.py | Update imports for new parts.microcontroller structure. |
| edg/parts/microcontroller/Ice40up.py | Update imports + move header connector import to parts.connector. |
| edg/parts/microcontroller/EspCommon.py | Update imports + move connector imports to parts.connector. |
| edg/parts/microcontroller/Esp32s3.py | Update imports + switch to EspCommon naming. |
| edg/parts/microcontroller/Esp32c3.py | Update imports + switch to EspCommon naming. |
| edg/parts/microcontroller/Esp32.py | Update imports + switch to EspCommon naming. |
| edg/parts/microcontroller/init.py | Export microcontroller parts. |
| edg/parts/logic/SpiMemory_W25q.py | Update imports for new parts.logic structure. |
| edg/parts/logic/SpiMemory_93Lc.py | Update imports for new parts.logic structure. |
| edg/parts/logic/py.typed | Mark parts.logic as typed package. |
| edg/parts/logic/Logic_74Lvc.py | Update imports for new parts.logic structure. |
| edg/parts/logic/Logic_74Ahct.py | Update imports for new parts.logic structure. |
| edg/parts/logic/init.py | Export logic parts. |
| edg/parts/Jacdac.py | Update JLC import path under new vendor package. |
| edg/parts/interface/UsbUart_Cp2102.py | Update imports for new parts.interface structure. |
| edg/parts/interface/UsbPd_Fusb302b.py | Update imports for new parts.interface structure. |
| edg/parts/interface/UsbInterface_Ft232h.py | Update imports + move SPI memory import to parts.logic. |
| edg/parts/interface/test_sx1262.py | Add unit test for SX1262 matching helper math. |
| edg/parts/interface/test_nfc.py | Add unit tests for NFC impedance/matching helper math. |
| edg/parts/interface/RfModules.py | Update imports for new parts.interface structure. |
| edg/parts/interface/Rf_Sx1262.py | Update imports for new parts.interface structure. |
| edg/parts/interface/Rf_Pn7160.py | Update imports for new parts.interface structure. |
| edg/parts/interface/ResetGenerator_Apx803s.py | Update imports for new parts.interface structure. |
| edg/parts/interface/py.typed | Mark parts.interface as typed package. |
| edg/parts/interface/Isolator_Cbmud1200.py | Update imports for new parts.interface structure. |
| edg/parts/interface/IoExpander_Pcf8574.py | Update imports for new parts.interface structure. |
| edg/parts/interface/IoExpander_Pca9554.py | Update typing/imports for new parts.interface structure. |
| edg/parts/interface/CanTransceiver_Sn65hvd230.py | Update imports for new parts.interface structure. |
| edg/parts/interface/CanTransceiver_Iso1050.py | Update imports for new parts.interface structure. |
| edg/parts/interface/CanBlocks.py | Update imports for new parts.interface structure. |
| edg/parts/interface/init.py | Export interface parts. |
| edg/parts/human_interface/Speakers.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/SpeakerDriver_Max98357a.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/SpeakerDriver_Analog.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/RotaryEncoder_Bourns.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/RotaryEncoder_Alps.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/py.typed | Mark parts.human_interface as typed package. |
| edg/parts/human_interface/Neopixel.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/Microphone_Sd18ob261.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/Joystick_Xbox.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/DirectionSwitch_Alps.py | Update imports for new parts.human_interface structure. |
| edg/parts/human_interface/init.py | Export human-interface parts. |
| edg/parts/display/Waveshare_Epd.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/py.typed | Mark parts.display as typed package. |
| edg/parts/display/oled/py.typed | Mark parts.display.oled as typed package. |
| edg/parts/display/oled/Nhd_312_25664uc.py | Update imports for new parts.display.oled structure. |
| edg/parts/display/oled/Er_Oled_096_1c.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/oled/Er_Oled_096_1_1.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/oled/Er_Oled_091_3.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/oled/Er_Oled_028.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/oled/Er_Oled_022.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/oled/init.py | Export OLED display parts. |
| edg/parts/display/lcd/Qt096t_if09.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/lcd/py.typed | Mark parts.display.lcd as typed package. |
| edg/parts/display/lcd/Er_Tft1_28_3.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/lcd/Ch280qv10_Ct.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/lcd/init.py | Export LCD display parts. |
| edg/parts/display/EInkBoostPowerPath.py | Update imports for new parts.display structure. |
| edg/parts/display/EInk_Er_Epd027_2.py | Update imports + move FPC connector import to parts.connector. |
| edg/parts/display/init.py | Export display subpackages/parts. |
| edg/parts/debug/TestPoint_Rc.py | Update imports for new parts.debug structure. |
| edg/parts/debug/TestPoint_Keystone.py | Update imports for new parts.debug structure. |
| edg/parts/debug/py.typed | Mark parts.debug as typed package. |
| edg/parts/debug/Jumpers.py | Update imports for new parts.debug structure. |
| edg/parts/debug/init.py | Export debug parts. |
| edg/parts/connector/UsbPorts.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/connector/TagConnect.py | Update imports for new parts.connector structure. |
| edg/parts/connector/SwdHeaders.py | Update imports + move headers/tagconnect imports to new connector modules. |
| edg/parts/connector/SdCards.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/connector/Rf.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/connector/py.typed | Mark parts.connector as typed package. |
| edg/parts/connector/Headers.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/connector/Fpc.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/connector/FanConnector.py | Update imports for new parts.connector structure. |
| edg/parts/connector/Connectors.py | Update imports + move header import to parts.connector.Headers. |
| edg/parts/connector/Banana.py | Update imports for new parts.connector structure. |
| edg/parts/connector/init.py | Export connector parts and applications. |
| edg/parts/analog/switch/py.typed | Mark parts.analog.switch as typed package. |
| edg/parts/analog/switch/Nlas4157.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/switch/Logic74xx.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/switch/Dg468.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/switch/init.py | Export analog switch parts. |
| edg/parts/analog/SolidStateRelay_Toshiba.py | Update imports for new parts.analog structure. |
| edg/parts/analog/SolidStateRelay_G3VM_61GR2.py | Update imports for new parts.analog structure. |
| edg/parts/analog/py.typed | Mark parts.analog as typed package. |
| edg/parts/analog/opamp/Tlv915x.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Tlv9061.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/py.typed | Mark parts.analog.opamp as typed package. |
| edg/parts/analog/opamp/Opax333.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Opax197.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Opax189.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Opax171.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Mcp6001.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Lmv321.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Ina826.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/Ina219.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/opamp/init.py | Export op-amp / analog front-end parts. |
| edg/parts/analog/dac/py.typed | Mark parts.analog.dac as typed package. |
| edg/parts/analog/dac/Mcp4901.py | Update imports for new parts.analog.dac structure. |
| edg/parts/analog/dac/Mcp47f.py | Update imports for new parts.analog.dac structure. |
| edg/parts/analog/dac/Mcp4728.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/dac/init.py | Export DAC parts. |
| edg/parts/analog/CurrentSense_Ad8418.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/Comparator_Lmv331.py | Update imports + move JLC part mixin to vendor_parts.jlc. |
| edg/parts/analog/adc/py.typed | Mark parts.analog.adc as typed package. |
| edg/parts/analog/adc/Mcp3561.py | Update imports for new parts.analog.adc structure. |
| edg/parts/analog/adc/Mcp3201.py | Update imports for new parts.analog.adc structure. |
| edg/parts/analog/adc/init.py | Export ADC parts. |
| edg/parts/analog/init.py | Export analog subpackages and parts. |
| edg/circuits/test_diodemerge.py | Update imports for new edg.circuits and abstract_parts usage. |
| edg/circuits/SwitchMatrix.py | Add reusable switch-matrix circuit generator. |
| edg/circuits/resources/README.md | Add documentation file for circuits/resources. |
| edg/circuits/ResistiveSensor.py | Add reusable resistive-sensor connector/voltage-divider circuit. |
| edg/circuits/py.typed | Mark circuits as typed package. |
| edg/circuits/LedMatrix.py | Minor import organization in LED matrix circuit. |
| edg/circuits/BootstrapVoltageAdder.py | Add bootstrap voltage-adder circuit (KiCad-import backed). |
| edg/circuits/init.py | Export circuits library surface. |
| edg/BoardTop.py | Re-export new vendor_parts and circuits packages from board top. |
| edg/init.py | Re-export vendor_parts/circuits at edg top-level API. |
Comments suppressed due to low confidence (2)
edg/vendor_parts/jlc/test_kicad_import_jlc.py:5
- Typo in comment:
KicadJlcBackBoxdoesn’t match the actual symbol name (KiCadJlcBlackbox). Update the comment to the correct name to avoid confusion when navigating imports.
edg/vendor_parts/jlc/PriceGetter.py:10 - This module looks for an optional
resources/supplemental_price.csv, but there is no such file underedg/vendor_parts/jlc/resources/(and the previousedg/parts/resources/supplemental_price.csvwas removed). As written, the supplementary pricing path is dead and will never be loaded; either move/restore the file to this package’s resources directory or remove/update the logic and documentation accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| for toplevel_item in Path().iterdir(): | ||
| if toplevel_item.is_dir(): | ||
| for file in toplevel_item.iterdir(): |
Comment on lines
+55
to
+56
| from .SwdHeaders import SwdCortexTargetHeader | ||
| from .SwdHeaders import SwdCortexTargetTc2050, SwdCortexTargetTagConnect, SwdCortexTargetTc2050 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 243 out of 290 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
edg/vendor_parts/jlc/test_kicad_import_jlc.py:5
- Comment typo:
KicadJlcBackBoxdoesn’t match the actual class/module naming (KiCadJlcBlackbox). Fixing the comment will make the intent clearer when navigating these tests.
Comment on lines
+39
to
+40
| [tool.setuptools.package-data] | ||
| edg = ["core/resources/edg-compiler-precompiled.jar", "electronics_model/resources/kicad_footprints.json", "abstract_parts/resources/*.kicad_sch", "parts/resources/Pruned_JLCPCB SMT Parts Library(20220419).csv", "parts/resources/*.kicad_sch"] | ||
| "edg" = ["core/resources/edg-compiler-precompiled.jar", "**/*.kicad_sch", "**/*.json", "**/*.csv"] |
Comment on lines
+54
to
+56
| # Applications | ||
| from .SwdHeaders import SwdCortexTargetHeader | ||
| from .SwdHeaders import SwdCortexTargetTc2050, SwdCortexTargetTagConnect, SwdCortexTargetTc2050 |
Comment on lines
+4
to
+6
| for toplevel_item in Path().iterdir(): | ||
| if toplevel_item.is_dir(): | ||
| for file in toplevel_item.iterdir(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sub-package structure to the parts library. Refactors pyproject.toml to auto-discover packages and include package data by extension.
Breaks some of them into vendor_parts (implementations of abstract_parts, including the JLC library) and circuits (which are solely composed of abstract parts).
A follow-on PR will break up electronics_model (separating out electronics_interfaces) and abstract_parts (moving stuff into circuits)
Related: #479