Skip to content

Unnecessary cast in toBTC() #114

@hlynx

Description

@hlynx

/src/BitcoinLib.php [1011]

public static function toBTC($satoshi)
{
    return bcdiv((int)(string)$satoshi, 100000000, 8);
}

Looks like it will silently fail on type overflow with 32-bit integer.
bcdiv works with strings. So omiting that cast looks apropriate:

bcdiv((string)$satoshi, 100000000, 8);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions