Skip to content

Commit 8bd8f79

Browse files
committed
fix(pkg): ship JoltPhysics/Build/ — bloom_jolt depends on its CMakeLists
0.3.2's tarball only shipped JoltPhysics/Jolt/, but bloom_jolt's CMakeLists does add_subdirectory(JoltPhysics/Build) — that directory's CMakeLists.txt is Jolt's primary cmake source (despite the directory name suggesting build output). Without it, downstream consumers hit: JoltPhysics submodule not found at .../JoltPhysics Run: git submodule update --init --recursive …which is misleading: the submodule is present, just incomplete. Adds JoltPhysics/Build/** to files: and removes the matching exclusion from .npmignore. The samples/unit-tests/hello-world/perf/viewer paths inside Build/CMakeLists.txt are guarded by a CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR check and only fire when Build/ is the top level, so we don't need TestFramework/, UnitTests/, etc. Tarball: 2.0 MB → 2.2 MB packed.
1 parent e3bda34 commit 8bd8f79

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.npmignore

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,15 @@ native/web/pkg/
1414

1515
# Native build dirs
1616
native/third_party/bloom_jolt/build/
17-
native/third_party/JoltPhysics/Build/
1817

1918
# Jolt submodule extras we don't need at consumer build time.
20-
# We only ship JoltPhysics/Jolt/ (the actual sources our cmake builds
21-
# against) plus LICENSE + README. Everything else is samples, viewer,
22-
# docs, assets, tests — multi-MB and irrelevant for embedding.
19+
# We ship JoltPhysics/Jolt/ (the actual sources) plus Build/ (its
20+
# primary CMakeLists — bloom_jolt does add_subdirectory(Build)),
21+
# plus LICENSE + README. Everything else is samples, viewer, docs,
22+
# assets, tests — multi-MB and irrelevant for embedding.
2323
native/third_party/JoltPhysics/.git
2424
native/third_party/JoltPhysics/.github/
2525
native/third_party/JoltPhysics/Assets/
26-
native/third_party/JoltPhysics/Build/
2726
native/third_party/JoltPhysics/Docs/
2827
native/third_party/JoltPhysics/HelloWorld/
2928
native/third_party/JoltPhysics/JoltViewer/

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@bloomengine/engine",
3-
"version": "0.3.2",
3+
"version": "0.3.3",
44
"description": "Bloom Engine: native TypeScript game engine compiled by Perry",
55
"main": "src/index.ts",
66
"types": "src/index.ts",
@@ -60,6 +60,7 @@
6060
"native/third_party/bloom_jolt/include/**",
6161
"native/third_party/bloom_jolt/src/**",
6262
"native/third_party/JoltPhysics/Jolt/**",
63+
"native/third_party/JoltPhysics/Build/**",
6364
"native/third_party/JoltPhysics/LICENSE",
6465
"native/third_party/JoltPhysics/README.md"
6566
],

0 commit comments

Comments
 (0)