Skip to content

[REFACTOR] Clean up residual nullable annotations in auxiliary models #1799

@purplesmoke05

Description

@purplesmoke05

Background

Several smaller TODO items remain in auxiliary models and routers, including node.endpoint_uri, token_holders_list.batch_status, and stale token lock assertions whose underlying ORM model is already non-nullable. These items are individually small, but together they still create noise and unnecessary defensive code.

Description

Audit the remaining low-scope nullable annotations and stale TODO comments in supporting models, then either enforce the missing database guarantees or remove the outdated guards when the guarantees already exist. The goal is to finish the small cleanup work without folding it into the larger domain-specific refactors.

Scope

  • Review Node.endpoint_uri usage in the Ethereum JSON-RPC router.
  • Review TokenHoldersList.batch_status typing and collection endpoints.
  • Remove stale token lock TODOs and assertions where IDXLockedPosition already guarantees non-null values.
  • Update affected model typing, router code, and targeted tests.
  • Exclude listing, notification, transfer, and bond-token refactors that already have their own issue drafts.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request
No fields configured for Feature.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions