From 18f6395bf31e0419f22d8b52b9de6501dc50393c Mon Sep 17 00:00:00 2001
From: Tamir Duberstein <tamird@gmail.com>
Date: Sun, 16 Aug 2026 07:17:16 -0500
Subject: [PATCH] Skip clone metadata for apparent sizes

Combining apparent-size reporting with APFS clone deduplication still
requests extended clone metadata even though logical sizes never use
it. Explicit file roots also perform unnecessary attribute lookups.

Disable clone metadata whenever apparent sizes are requested while
preserving both accepted command-line flags. Cover all four flag
combinations in the shared traversal-options constructor.
---
 src/main.rs | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/src/main.rs b/src/main.rs
index afba8e18..d1616b80 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -346,7 +346,7 @@ fn walk_options_from(traversal: &options::TraversalArgs) -> Result<dua::WalkOpti
         ignore_patterns: dua::IgnorePatterns::from_files(&traversal.ignore_from)?,
         metadata_options: dua::TraversalOptions {
             #[cfg(target_os = "macos")]
-            apfs_clone_metadata: traversal.deduplicate_apfs_clones,
+            apfs_clone_metadata: traversal.deduplicate_apfs_clones && !traversal.apparent_size,
         },
     };
 
@@ -627,6 +627,36 @@ mod tests {
         );
     }
 
+    #[cfg(target_os = "macos")]
+    #[test]
+    fn walk_options_only_request_apfs_clones_for_allocated_size() {
+        for (apparent_size, deduplicate_apfs_clones, expected_clone_metadata) in [
+            (false, false, false),
+            (false, true, true),
+            (true, false, false),
+            (true, true, false),
+        ] {
+            let traversal = super::options::TraversalArgs {
+                threads: 1,
+                format: None,
+                apparent_size,
+                count_hard_links: false,
+                deduplicate_apfs_clones,
+                stay_on_filesystem: false,
+                ignore_dirs: vec![],
+                ignore_from: vec![],
+                input: vec![],
+            };
+            let walk_options =
+                super::walk_options_from(&traversal).expect("valid traversal options");
+
+            assert_eq!(
+                walk_options.metadata_options.apfs_clone_metadata, expected_clone_metadata,
+                "apparent_size={apparent_size}, deduplicate_apfs_clones={deduplicate_apfs_clones}"
+            );
+        }
+    }
+
     #[test]
     fn merge_traversal_args_prefers_global_threads() {
         let custom_threads = super::options::DEFAULT_THREADS + 1;