Skip to content

Commit 892e3c3

Browse files
authored
vulkan: disable mmvq on Intel Windows driver (ggml-org#20672)
* vulkan: disable mmvq on Intel Windows driver * improve comment
1 parent ee4801e commit 892e3c3

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

ggml/src/ggml-vulkan/ggml-vulkan.cpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7646,20 +7646,14 @@ static bool ggml_vk_should_use_mmvq(const vk_device& device, uint32_t m, uint32_
76467646
return true;
76477647
}
76487648
case VK_VENDOR_ID_INTEL:
7649-
if (k < 2048) {
7649+
if (device->driver_id == vk::DriverId::eIntelProprietaryWindows) {
7650+
// Intel Windows proprietary driver MMVQ performance is worse than fp16, see
7651+
// https://github.com/ggml-org/llama.cpp/issues/17628
76507652
return false;
76517653
}
76527654

7653-
if (device->driver_id == vk::DriverId::eIntelProprietaryWindows) {
7654-
// Intel Windows proprietary driver tuning
7655-
switch (src0_type) {
7656-
case GGML_TYPE_MXFP4:
7657-
case GGML_TYPE_Q4_K:
7658-
case GGML_TYPE_Q5_K:
7659-
return false;
7660-
default:
7661-
return true;
7662-
}
7655+
if (k < 2048) {
7656+
return false;
76637657
}
76647658

76657659
switch (src0_type) {

0 commit comments

Comments
 (0)