Skip to content

Nullable notification text relies on deprecated coercion #814

Description

@somethingwithproof

thold_str_replace() declares a non-null string notification subject, while notification fields such as snmp_event_description are nullable. With the repository's coercive typing, PHP 8.1 accepts null but emits E_DEPRECATED; relying on that deprecated conversion makes the notification path noisy today and incompatible with stricter future behavior.

Allow only the subject to be nullable and normalize a null subject to empty text. Keep the search tag typed as string and preserve existing replacement-value behavior, so the shared helper does not silently broaden its contract. Add a regression that captures and rejects any E_DEPRECATED from the null-subject boundary.

Fresh overlap audit: no open plugin_thold PR addresses this nullable-subject path.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions