fix: some hard crash and timing issues

Author: didinele

packages/bot/src/struct/JobManager.ts

@@ -94,7 +94,7 @@ export class JobManager {
 							.catch(() => null)) as ThreadChannel | null;
 
 						if (channel?.archived) {
-							await channel.setArchived(false);
+							await channel.setArchived(false).catch(() => null);
 						}
 
 						const payload: Payload = { op: PayloadOpCode.Done };

packages/bot/src/util/handleStaffThreadMessage.ts

@@ -18,16 +18,17 @@ export async function handleStaffThreadMessage(
 	interaction: ChatInputCommandInteraction<'cached'>,
 	action: HandleStaffThreadMessageAction,
 ) {
-	const prisma = container.resolve(PrismaClient);
+	await interaction.deferReply({ ephemeral: true });
 
+	const prisma = container.resolve(PrismaClient);
 	const thread = await prisma.thread.findFirst({
 		where: {
 			channelId: interaction.channelId,
 			closedById: null,
 		},
 	});
 	if (!thread) {
-		return interaction.reply(i18next.t('common.errors.no_thread'));
+		return interaction.editReply(i18next.t('common.errors.no_thread'));
 	}
 
 	let options: Partial<SendStaffThreadMessageOptions> = {
@@ -42,7 +43,7 @@ export async function handleStaffThreadMessage(
 
 	const member = await interaction.guild.members.fetch(thread.userId).catch(() => null);
 	if (!member) {
-		return interaction.reply(i18next.t('common.errors.no_member', { lng: interaction.locale }));
+		return interaction.editReply(i18next.t('common.errors.no_member', { lng: interaction.locale }));
 	}
 
 	options.member = member;
@@ -59,7 +60,7 @@ export async function handleStaffThreadMessage(
 			},
 		});
 		if (!threadMessage) {
-			return interaction.reply(
+			return interaction.editReply(
 				i18next.t('common.errors.resource_not_found', {
 					resource: 'message',
 					lng: interaction.locale,
@@ -68,13 +69,13 @@ export async function handleStaffThreadMessage(
 		}
 
 		if (threadMessage.staffId !== interaction.user.id) {
-			return interaction.reply(i18next.t('common.errors.not_own_message', { lng: interaction.locale }));
+			return interaction.editReply(i18next.t('common.errors.not_own_message', { lng: interaction.locale }));
 		}
 
 		const clearAttachment = interaction.options.getBoolean('clear-attachment');
 
 		if (attachment && clearAttachment) {
-			return interaction.reply(
+			return interaction.editReply(
 				i18next.t('common.errors.arg_conflict', {
 					first: 'attachment',
 					second: 'clear-attachment',

packages/bot/src/util/sendStaffThreadMessage.ts

@@ -101,7 +101,7 @@ export async function sendStaffThreadMessage({
 	}
 
 	if (existing) {
-		await interaction?.reply({ content: 'Successfully edited your message' });
+		await interaction?.editReply({ content: 'Successfully edited your message' });
 		setTimeout(async () => {
 			try {
 				await interaction?.deleteReply();
@@ -114,7 +114,7 @@ export async function sendStaffThreadMessage({
 	}
 
 	const guildMessage = await channel.send(options as MessageCreateOptions);
-	await interaction?.reply({ content: 'Successfully posted your message' });
+	await interaction?.editReply({ content: 'Successfully posted your message' });
 	setTimeout(async () => {
 		try {
 			await interaction?.deleteReply();