Skip to content

Commit a0760ec

Browse files
authored
Merge branch 'Checkmk:master' into rs_notification_parameters_doc_improvement
2 parents 4cd1fdd + 101c6ce commit a0760ec

238 files changed

Lines changed: 37239 additions & 21373 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.bazelrc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@ build --workspace_status_command=bazel/tools/workspace_status.sh
88
# Add mirrors for certain download URLs
99
common --downloader_config=bazel_downloader.cfg
1010

11+
# Limit JVM thread pools to match cgroup CPU limit (nproc reports host CPUs, not cgroup)
12+
# --host_jvm_args is a startup option, see https://bazel.build/run/bazelrc
13+
startup --host_jvm_args=-XX:ActiveProcessorCount=8
14+
startup --host_jvm_args=-XX:ParallelGCThreads=4
15+
startup --host_jvm_args=-XX:ConcGCThreads=2
16+
1117
# enable a local disk cache: this is especially relevant for local builds without an enabled bazel-remote
1218
common:linux --disk_cache=~/.cache/bazel_disk_cache/
1319
common:linux --experimental_disk_cache_gc_max_size=100G
File renamed without changes.

.github/agents/code-review.agent.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ You are an expert code reviewer at Checkmk. Your job is to find **problems** in
3434
- Find related tests if the change affects testable behavior
3535
- If fixing a bug, search for the same pattern elsewhere that may have the same issue
3636
3. **Review the change given the context**
37-
4. **Report back in standardized output format:**
37+
4. **Report back in standardized output format.** Note that the 4 backticks help to display raw text to be copy & pasted.
3838

3939
<output-format>
4040
# Change <number>: <one-line summary>
@@ -61,10 +61,13 @@ If the change reveals broader issues or incomplete fixes:
6161

6262
**<file>:<line>**
6363

64+
<!-- prettier-ignore -->
65+
````markdown
6466
Brief explanation of the problem and why it matters (1-3 sentences).
6567
Include a code snippet if it clarifies the issue.
6668

6769
Suggest a concrete fix, or list options if there are multiple valid approaches.
70+
````
6871

6972
</issue-1>
7073

@@ -75,7 +78,11 @@ Suggest a concrete fix, or list options if there are multiple valid approaches.
7578

7679
**<file>:<line>**
7780

81+
<!-- prettier-ignore -->
82+
````markdown
7883
...
84+
````
85+
7986
</issue-2>
8087
</list-of-issues>
8188
</output-format>
@@ -143,6 +150,7 @@ Good addition for controlling request timeouts, but there's a potential issue wi
143150

144151
**cmk/base/sources/\_api.py:142**
145152

153+
````markdown
146154
The default timeout of `0` will cause immediate timeout errors in production.
147155
Looking at the underlying `requests` library usage:
148156

@@ -161,6 +169,8 @@ To fix this:
161169
- Make the parameter required to force callers to choose explicitly
162170

163171
I'd recommend option 2 with `timeout: float = 30.0` as a reasonable default.
172+
````
173+
164174
</good-example-minor-issues>
165175

166176
## Guidelines

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
.bugs/.last
33
.bugs/.my_ids
44
.cache
5-
.cargo
65
.coverage
76
.coverage.*
87
.directory

.werks/18744.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
[//]: # (werk v3)
2+
# OTel: Hosts monitored only via OpenTelemetry are incorrectly treated as ping hosts
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-03-19T09:28:02.224095+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | ultimate
10+
component | checks
11+
level | 1
12+
compatible | yes
13+
14+
Hosts configured to receive OpenTelemetry data but lacking a Checkmk agent or SNMP were incorrectly classified as ping-only. This caused their services to show an UNKNOWN state instead of processing the incoming OpenTelemetry metrics, leading to confusion or missed alerts.
15+
16+
We now correctly recognize hosts with an OpenTelemetry metrics association as having a valid data source. This fix ensures these hosts display their OpenTelemetry metrics accurately, improving monitoring reliability. No user action is required to benefit from this update.

.werks/19191.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
[//]: # (werk v3)
2+
# mk-sql: skip inaccessible databases in SQL Server Always On Availability Groups
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-03-20T12:34:51+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | community
10+
component | checks
11+
level | 2
12+
compatible | yes
13+
14+
mk-sql previously queried all SQL Server databases indiscriminately, including secondary replicas in Always On Availability Groups (AG) that were not directly accessible. This caused spurious errors when monitoring SQL Server instances participating in an AG.
15+
16+
Now, mk-sql only queries databases that are actually accessible: standalone databases, primary replicas, and readable secondary replicas. Inaccessible AG secondaries are silently skipped — this is expected behavior, not an error.
17+
18+
This change improves monitoring reliability by eliminating false error messages. No configuration adjustments are necessary, as the update is fully automatic and transparent to users.

.werks/19343.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
[//]: # (werk v3)
2+
# Enforce "Query metric backend from custom graph editor" permission on graph view, edit and AJAX endpoints
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-03-20T09:18:51+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | ultimate
10+
component | wato
11+
level | 1
12+
compatible | yes
13+
14+
The "Query metric backend from custom graph editor" permission now restricts access to the graph view, edit, and AJAX endpoints. Previously, all users—regardless of this permission—could query the metric backend.
15+
16+
With this change, only users granted this permission are allowed to query the metric backend.
17+
18+
No action is required to benefit from this update.

.werks/19512.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
[//]: # (werk v3)
2+
# Agent connection test: Token generation only shown for tabs that need it
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-03-19T09:32:09+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | community
10+
component | wato
11+
level | 1
12+
compatible | yes
13+
14+
In the community edition, the agent connection test slide-out always showed the
15+
token generation prompt, even for tabs that only display a documentation link
16+
and do not need a token. This was confusing but not blocking.
17+
18+
The token generation is now only shown for tabs that actually include install
19+
commands requiring a token.

.werks/19522.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
[//]: # (werk v3)
2+
# Fix crash when viewing parameters for services of third-party check plugins
3+
4+
key | value
5+
---------- | ---
6+
date | 2026-03-19T12:11:17.079858+00:00
7+
version | 2.6.0b1
8+
class | fix
9+
edition | community
10+
component | wato
11+
level | 1
12+
compatible | yes
13+
14+
Previously, opening the "Parameters for service" page in Setup for a
15+
discovered service could crash with a KeyError if the check plugin's
16+
checkgroup had no registered ruleset — which is common for third-party
17+
check plugins (e.g. infortend_chassis1).
18+
19+
The page now correctly shows "This check is not configurable via Setup"
20+
for such services instead of crashing with an internal error.

0 commit comments

Comments
 (0)