Refonte complète de la Map Insa#2
Open
pierrbt wants to merge 7 commits into
Open
Conversation
made partially with opencode ai assistant
ignyx
requested changes
Apr 7, 2026
ignyx
left a comment
ignyx
left a comment
There was a problem hiding this comment.
Super refonte ! Merci !
J'ai souligné quelques détails.
Aussi, je ne suis pas sûr de bien comprendre la recherche. Quand je clique sur une des suggestions, il ne semble rien se passer.
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
|
|
||
| <!-- Primary Meta Tags --> | ||
| <title>Map-INSA</title> |
There was a problem hiding this comment.
Le titre pourrait bénéficier d'une refont, peut-être "Plan INSA Toulouse" ou qqch de similaire ?
| @@ -30,12 +28,8 @@ | |||
| property="og:description" | |||
| content="Find your way around the INSA Toulouse campus." | |||
There was a problem hiding this comment.
Cette description est en anglais, alors que la page est en français
| } | ||
|
|
||
| bootstrap().catch((error) => { | ||
| console.error(error); |
There was a problem hiding this comment.
ça me parait pertinent de rajouter une user-facing error (au moins un alert())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cette PR change complètement la carte avec les modifications suivantes :
Elle a pour but de faire une version plus récente à intégrer dans l'application campus de l'insa.
Le code a été partiellement généré par l'IA.
Ce code peut être vérifié par @ignyx
Je dois encore travailler sur l'optimisation fine, cela sera proposé dans une PR ultérieure.
Pierre