- checkpoint: refactor configuration validation

Author: NinjaRocks

README.md

@@ -86,7 +86,7 @@ Please see [Release Roadmap](https://github.com/CodeShayk/TurboMapper/blob/maste
 - **Conditional Mapping**: Added When method to IMappingExpression for conditional property mapping
 - **Mapping Transformations**: Added MapWith method for transformation functions during mapping
 - **Comprehensive Type Conversions**: Enhanced ConvertValue with DateTime, TimeSpan, and other common type conversions
-- **Configuration Validation**: Added ValidateMapping and GetMappingErrors methods to IMapper for early validation
+- **Configuration Validation**: Added ValidateMapping method to IMapper that returns ValidationResult for early validation
 - **Improved Error Messages**: Better debugging information for conversion failures
 
 ## Contributing

src/TurboMapper/IMapper.cs

@@ -6,8 +6,9 @@ namespace TurboMapper
     public interface IMapper
     {
         TTarget Map<TSource, TTarget>(TSource source);
+
         IEnumerable<TDestination> Map<TSource, TDestination>(IEnumerable<TSource> source);
-        bool ValidateMapping<TSource, TTarget>();
-        string[] GetMappingErrors<TSource, TTarget>();
+
+        ValidationResult ValidateMapping<TSource, TTarget>();
     }
 }

src/TurboMapper/Impl/Mapper.cs

@@ -201,13 +201,7 @@ private bool IsIgnoredInCustomMappings(string targetPropertyName, List<PropertyM
         // Custom converter system
         private readonly Dictionary<string, Delegate> _converters = new Dictionary<string, Delegate>();
 
-        public bool ValidateMapping<TSource, TTarget>()
-        {
-            var errors = GetMappingErrors<TSource, TTarget>();
-            return errors.Length == 0;
-        }
-
-        public string[] GetMappingErrors<TSource, TTarget>()
+        public ValidationResult ValidateMapping<TSource, TTarget>()
         {
             var errors = new List<string>();
             var sourceType = typeof(TSource);
@@ -241,7 +235,8 @@ public string[] GetMappingErrors<TSource, TTarget>()
                 }
             }
 
-            return errors.ToArray();
+            var isValid = errors.Count == 0;
+            return new ValidationResult(isValid, errors);
         }
 
         private bool PropertyExists(Type type, string propertyPath)

src/TurboMapper/ValidationResult.cs

@@ -0,0 +1,21 @@
+using System.Collections.Generic;
+
+namespace TurboMapper
+{
+    public class ValidationResult
+    {
+        public bool IsValid { get; set; }
+        public IEnumerable<string> Errors { get; set; }
+        
+        public ValidationResult()
+        {
+            Errors = new List<string>();
+        }
+        
+        public ValidationResult(bool isValid, IEnumerable<string> errors)
+        {
+            IsValid = isValid;
+            Errors = errors ?? new List<string>();
+        }
+    }
+}

tests/TurboMapper.Tests/Release120_Tests.cs

@@ -291,11 +291,10 @@ public void Task6_2_ConfigurationValidation()
             mapper.CreateMap<Person, PersonDto>(new List<PropertyMapping>());
 
             // Validate the mapping
-            var isValid = mapper.ValidateMapping<Person, PersonDto>();
-            var errors = mapper.GetMappingErrors<Person, PersonDto>();
+            var validationResult = mapper.ValidateMapping<Person, PersonDto>();
 
-            Assert.IsTrue(isValid, string.Join(", ", errors));
-            Assert.AreEqual(0, errors.Length);
+            Assert.IsTrue(validationResult.IsValid, string.Join(", ", validationResult.Errors));
+            Assert.AreEqual(0, validationResult.Errors.Count());
         }
 
         // Test models