From 160524c3427a782650051a4dea493b88b5b1e5b3 Mon Sep 17 00:00:00 2001 From: Maryanne Mosonik Date: Tue, 21 Apr 2026 21:38:58 +0300 Subject: [PATCH 1/3] Fix book submission bugs. --- debugging/book-library/script.js | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..5665f9db 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -2,7 +2,6 @@ let myLibrary = []; window.addEventListener("load", function (e) { populateStorage(); - render(); }); function populateStorage() { @@ -29,16 +28,15 @@ const check = document.getElementById("check"); //via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || + title.value == ""|| + author.value == "" || pages.value == "" ) { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } @@ -54,7 +52,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -76,7 +74,7 @@ function render() { changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); let readStatus = ""; - if (myLibrary[i].check == false) { + if (myLibrary[i].check == true) { readStatus = "Yes"; } else { readStatus = "No"; @@ -90,11 +88,11 @@ function render() { //add delete button to every row and render again let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delButton.id = i; + deleteCell.appendChild(delButton); + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From 1d10c7d7d1ac74afaee8c9ebbd123ecb2b16fb27 Mon Sep 17 00:00:00 2001 From: Maryanne Mosonik Date: Wed, 22 Apr 2026 00:58:40 +0300 Subject: [PATCH 2/3] Refactor HTML structure and improve form input types --- debugging/book-library/index.html | 37 +++++++++++++------------------ 1 file changed, 15 insertions(+), 22 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..e531f8ef 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,21 @@ - + - + Book Library + + > - + > + @@ -31,20 +32,20 @@

Library

+ > + > Library id="pages" name="pages" required - /> + > + >
@@ -80,15 +81,7 @@

Library

- - - - - - - - - + From bd831e3a550903dd77fc2d2fb4c2f31cb00372ef Mon Sep 17 00:00:00 2001 From: Maryanne Mosonik Date: Wed, 22 Apr 2026 21:58:00 +0300 Subject: [PATCH 3/3] Made further debugging changes to index.html and script.js --- debugging/book-library/index.html | 2 +- debugging/book-library/script.js | 123 ++++++++++++++++-------------- 2 files changed, 67 insertions(+), 58 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index e531f8ef..49aed8a9 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -70,7 +70,7 @@

Library

> - +
diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 5665f9db..bc620f65 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,4 +1,4 @@ -let myLibrary = []; +const myLibrary = []; window.addEventListener("load", function (e) { populateStorage(); @@ -6,11 +6,11 @@ window.addEventListener("load", function (e) { function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1); @@ -19,26 +19,29 @@ function populateStorage() { } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == ""|| - author.value == "" || - pages.value == "" - ) { + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); + const isRead = checkInput.checked; + if (!title || !author || pagesInput.value.trim() === "" ) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, author.value, pages.value, check.checked); - myLibrary.push(book); - render(); + return; + } + if (Number.isNaN(pages) || pages <= 0) { + alert("Please enter a valid number of pages!"); + return; } + const book = new Book(title, author, pages, isRead); + myLibrary.push(book); + render(); } function Book(title, author, pages, check) { @@ -48,54 +51,60 @@ function Book(title, author, pages, check) { this.check = check; } +function showMessage(text) { + const msg = document.getElementById("message"); + msg.innerText = text; + + setTimeout(() => { + msg.innerText = ""; + }, 2000); +} + function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; + const table = document.getElementById("display"); + + table.innerHTML = table.rows[0].outerHTML; + myLibrary.forEach((book, index) => { + const row = table.insertRow(); + + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.innerText = book.title; + authorCell.innerText = book.author; + pagesCell.innerText = book.pages; + //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == true) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + const toggleReadButton = document.createElement("button"); + toggleReadButton.className = "btn btn-success"; + toggleReadButton.innerText = book.check ? "Yes" : "No"; + + toggleReadButton.addEventListener("click", () => { + book.check = !book.check; render(); }); + wasReadCell.appendChild(toggleReadButton); + //add delete button to every row and render again - let delButton = document.createElement("button"); - delButton.id = i; - deleteCell.appendChild(delButton); - delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; - delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); + const deleteButton = document.createElement("button"); + deleteButton.className = "btn btn-warning"; + deleteButton.innerText = "Delete"; + + deleteButton.addEventListener("click", () => { + showMessage(`Book "${book.title}" deleted!`); + myLibrary.splice(index, 1); render(); }); - } + + deleteCell.appendChild(deleteButton); + }); } +