From 10b8a79004996666817ccad45d4e2ba6eef4cf92 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 2 Apr 2026 13:32:31 +0000 Subject: [PATCH 1/2] Initial plan From 3f7fb1ed2a153a73515edab5b046582bd727418d Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 2 Apr 2026 14:02:42 +0000 Subject: [PATCH 2/2] fix: label default font options in classic editor settings Agent-Logs-Url: https://github.com/Codeinwp/visualizer/sessions/430cefd8-53f0-427b-9bfb-ed1692347b7e Co-authored-by: HardeepAsrani <2649903+HardeepAsrani@users.noreply.github.com> --- classes/Visualizer/Render/Sidebar/ChartJS.php | 8 ++++---- classes/Visualizer/Render/Sidebar/Google.php | 4 ++-- .../Render/Sidebar/Type/ChartJS/Linear.php | 8 ++++---- tests/e2e/specs/admin.spec.js | 16 ++++++++++++++++ 4 files changed, 26 insertions(+), 10 deletions(-) diff --git a/classes/Visualizer/Render/Sidebar/ChartJS.php b/classes/Visualizer/Render/Sidebar/ChartJS.php index 7d4a433a..9dbff936 100644 --- a/classes/Visualizer/Render/Sidebar/ChartJS.php +++ b/classes/Visualizer/Render/Sidebar/ChartJS.php @@ -212,7 +212,7 @@ protected function _renderGeneralSettings() { echo ''; echo ''; echo ''; - echo ''; + echo ''; for ( $i = 7; $i <= 20; $i++ ) { echo ''; } @@ -263,7 +263,7 @@ protected function _renderGeneralSettings() { echo ''; echo ''; echo ''; - echo ''; + echo ''; for ( $i = 7; $i <= 20; $i++ ) { echo ''; } diff --git a/classes/Visualizer/Render/Sidebar/Google.php b/classes/Visualizer/Render/Sidebar/Google.php index 2684e297..64311268 100644 --- a/classes/Visualizer/Render/Sidebar/Google.php +++ b/classes/Visualizer/Render/Sidebar/Google.php @@ -187,7 +187,7 @@ protected function _renderGeneralSettings() { echo ''; echo ''; echo ''; - echo ''; + echo ''; for ( $i = 7; $i <= 20; $i++ ) { echo ''; } diff --git a/classes/Visualizer/Render/Sidebar/Type/ChartJS/Linear.php b/classes/Visualizer/Render/Sidebar/Type/ChartJS/Linear.php index 9205c7f4..b4c04ce5 100644 --- a/classes/Visualizer/Render/Sidebar/Type/ChartJS/Linear.php +++ b/classes/Visualizer/Render/Sidebar/Type/ChartJS/Linear.php @@ -161,7 +161,7 @@ protected function _renderHorizontalAxisGeneralSettings() { echo ''; echo ''; echo ''; - echo ''; + echo ''; for ( $i = 7; $i <= 20; $i++ ) { echo ''; } @@ -265,7 +265,7 @@ protected function _renderVerticalAxisGeneralSettings() { echo ''; echo ''; echo ''; - echo ''; + echo ''; for ( $i = 7; $i <= 20; $i++ ) { echo ''; } diff --git a/tests/e2e/specs/admin.spec.js b/tests/e2e/specs/admin.spec.js index 3534105a..90eb5c54 100644 --- a/tests/e2e/specs/admin.spec.js +++ b/tests/e2e/specs/admin.spec.js @@ -211,6 +211,22 @@ test.describe( 'Chart Library', () => { await expect( page.getByText(backendName) ).toBeVisible(); await expect( page.locator('g').filter({ hasText: 'Test Chart Name' }).locator('rect') ).toBeVisible(); } ); + + test( 'font settings show Default label for empty option', async ( { admin, page } ) => { + await admin.visitAdminPage( 'admin.php?page=visualizer&vaction=addnew' ); + await page.waitForURL( '**/admin.php?page=visualizer&vaction=addnew' ); + await expect( page.getByRole('button', { name: 'Classic Builder Step-by-step' }) ).toBeVisible({ timeout: 5000 }); + await page.getByRole('button', { name: 'Classic Builder Step-by-step' }).click(); + await page.waitForSelector('h1:text("Visualizer")'); + + await selectChartAdmin( page.frameLocator('iframe'), CHART_JS_LABELS.pie ); + await page.frameLocator('iframe').getByRole('link', { name: 'Settings' }).click(); + await page.frameLocator('iframe').getByRole('button', { name: 'General Settings' }).click(); + await page.frameLocator('iframe').getByText('Font Styles', { exact: true }).click(); + + await expect( page.frameLocator('iframe').locator('select[name="fontName"] option').first() ).toHaveText( 'Default' ); + await expect( page.frameLocator('iframe').locator('select[name="fontSize"] option').first() ).toHaveText( 'Default' ); + } ); } ); test.describe( 'Support', () => {