fix(build): ignore stdin on remote ssh so concurrent calls cannot dea…#4
Open
gabbelitoV2 wants to merge 1 commit into
Open
fix(build): ignore stdin on remote ssh so concurrent calls cannot dea…#4gabbelitoV2 wants to merge 1 commit into
gabbelitoV2 wants to merge 1 commit into
Conversation
…dlock cf runs ssh with stdin inherited from the interactive terminal. Building many recipes at once deadlocks the prefetch stage: concurrent prefetch ssh calls (mkdir and ISO existence check in captureRemote) plus a long build stream all share fd 0 and block each other, the classic parallel-ssh-eats-stdin footgun. A stalled prefetch never reaches its wget, so it holds a queue slot forever while the download itself takes seconds. Use stdin ignore (ssh -n) for the non-interactive captureRemote and the build stream; nothing there reads stdin. Verified on a 16-recipe build: prefetch runs 3 concurrent downloads with live progress instead of stalling at 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dlock
cf runs ssh with stdin inherited from the interactive terminal. Building many recipes at once deadlocks the prefetch stage: concurrent prefetch ssh calls (mkdir and ISO existence check in captureRemote) plus a long build stream all share fd 0 and block each other, the classic parallel-ssh-eats-stdin footgun. A stalled prefetch never reaches its wget, so it holds a queue slot forever while the download itself takes seconds. Use stdin ignore (ssh -n) for the non-interactive captureRemote and the build stream; nothing there reads stdin. Verified on a 16-recipe build: prefetch runs 3 concurrent downloads with live progress instead of stalling at 0.