fix(build): watchdog must not qm start a template#5
Open
gabbelitoV2 wants to merge 2 commits into
Open
Conversation
The build-VM watchdog restarts the VM when it has reported status stopped for 20s. A template also reports stopped, so once packer finishes and converts the VM to a template the watchdog calls qm start and gets the error you cannot start a vm if it is a template, repeatedly, until it burns through its restart limit. The build still passes (the error is swallowed) but the log is alarming and the watchdog wastes time. Check the template flag before restarting and exit cleanly instead.
…ding down The watchdog exits the moment the communicator port (SSH 22 / WinRM 5985) first responds. On Windows this races with Setup: WinRM opens briefly during OOBE, the watchdog exits, then Windows reboots or powers off for a later phase. With the watchdog gone the powered-off VM is never restarted and Packer waits out its full 4h timeout with no route to host, finishing with no artifact. Require the port to stay up for several consecutive checks (~30s) before standing down; a transient blip resets the counter and the watchdog keeps restarting the VM on power-off until the port is stably up (Packer connected and provisioning). Fixes the intermittent Windows builds that produced no template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-VM watchdog restarts the VM when it has reported status stopped for 20s. A template also reports stopped, so once packer finishes and converts the VM to a template the watchdog calls qm start and gets the error you cannot start a vm if it is a template, repeatedly, until it burns through its restart limit. The build still passes (the error is swallowed) but the log is alarming and the watchdog wastes time. Check the template flag before restarting and exit cleanly instead.