From 64c45d920751cec663b83a3977cf06e2aaa708d1 Mon Sep 17 00:00:00 2001 From: Jesse Kramer Date: Wed, 10 Mar 2021 11:45:48 +0100 Subject: [PATCH 1/4] Add PHPStan as dev dependency --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 6986b83..35af522 100644 --- a/composer.json +++ b/composer.json @@ -16,7 +16,7 @@ "require-dev": { "friendsofphp/php-cs-fixer": "^2.16", "php-http/mock-client": "^1.4", - "phpstan/phpstan": "^0.12", + "phpstan/phpstan": "^0.12.81", "phpunit/phpunit": "^8.5", "squizlabs/php_codesniffer": "^3.5", "monolog/monolog": "^2.1", From 3b3ea06fbfaaeb0b6af04367673ebed2db66e462 Mon Sep 17 00:00:00 2001 From: Jesse Kramer Date: Wed, 10 Mar 2021 11:49:38 +0100 Subject: [PATCH 2/4] Add PHPStan configuration and documentation --- README.md | 10 +++++++++- phpstan.neon | 4 ++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 phpstan.neon diff --git a/README.md b/README.md index f01299f..32b4f02 100644 --- a/README.md +++ b/README.md @@ -201,6 +201,14 @@ foreach ($domains as $domain) { } ``` +## Contributing + +When contributing to this project, you can run the following quality checks: + +```bash +$ vendor/bin/phpstan +``` + ## License The MIT License (MIT) @@ -223,4 +231,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -SOFTWARE. \ No newline at end of file +SOFTWARE. diff --git a/phpstan.neon b/phpstan.neon new file mode 100644 index 0000000..c3c98d3 --- /dev/null +++ b/phpstan.neon @@ -0,0 +1,4 @@ +parameters: + level: 0 + paths: + - src From 496a0c5ec91ee34c8fc2da5cf644e53112b3744f Mon Sep 17 00:00:00 2001 From: Jesse Kramer Date: Wed, 10 Mar 2021 11:57:18 +0100 Subject: [PATCH 3/4] Make sure FolderManager adheres to its interface (no bc breaks) --- src/Managers/FolderManager.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Managers/FolderManager.php b/src/Managers/FolderManager.php index 1f2aa94..6f9dde9 100644 --- a/src/Managers/FolderManager.php +++ b/src/Managers/FolderManager.php @@ -29,10 +29,12 @@ class FolderManager extends AbstractManager implements FolderManagerInterface, L * * @param int $page * @param int $perPage + * @param array $filters * @return \DnsMadeEasy\Pagination\Paginator|mixed + * @throws \DnsMadeEasy\Exceptions\Client\Http\HttpException * @throws \ReflectionException */ - public function paginate(int $page = 1, int $perPage = 20) + public function paginate(int $page = 1, int $perPage = 20, $filters = []) { $response = $this->client->get($this->getBaseUri()); $data = json_decode((string)$response->getBody()); @@ -79,4 +81,4 @@ protected function transformConciseApiData(object $data): object 'label' => $data->label, ]; } -} \ No newline at end of file +} From 722186d40e00192a78b9096deea8a7fa2aeddb70 Mon Sep 17 00:00:00 2001 From: Jesse Kramer Date: Wed, 10 Mar 2021 11:58:03 +0100 Subject: [PATCH 4/4] Add Illuminate/Pagination as a dependency --- composer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 35af522..46c413f 100644 --- a/composer.json +++ b/composer.json @@ -11,7 +11,8 @@ "guzzlehttp/psr7": "^1.7", "psr/log": "^1.1", "spatie/enum": "^3.6", - "guzzlehttp/guzzle": ">=6" + "guzzlehttp/guzzle": ">=6", + "illuminate/pagination": "^5.8|^6.0|^7.0|^8.0" }, "require-dev": { "friendsofphp/php-cs-fixer": "^2.16",