Allow cursor-based pagination to query extra page until collection is empty (#3790)

Mirrors DataDog/datadog-api-client-go#3769. Cursor paginators now keep
querying until the response data is empty, instead of stopping when a
page returns fewer items than the requested limit.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Author: nogates

.generator/src/generator/templates/Api.j2

@@ -205,7 +205,7 @@ public class {{ name }} {
   args.put("optionalParams", parameters);
   {%- endif  %}
 
-  PaginationIterable iterator = new PaginationIterable(this, "{{ operationId }}", resultsPath, valueGetterPath, valueSetterPath, valueSetterParamOptional, {% if pagination.pageParam %}false{% else %}true{% endif %}, limit, args, {{ pagination.pageStart | default(0) }});
+  PaginationIterable iterator = new PaginationIterable(this, "{{ operationId }}", resultsPath, valueGetterPath, valueSetterPath, valueSetterParamOptional, {% if pagination.pageParam %}false{% else %}true{% endif %}, {% if pagination.cursorParam %}true{% else %}false{% endif %}, limit, args, {{ pagination.pageStart | default(0) }});
 
   return iterator;
 {%- endmacro %}

.generator/src/generator/templates/PaginationIterable.j2

@@ -12,6 +12,7 @@ public class PaginationIterable<T> implements Iterable<T> {
   String[] valueSetterPath;
   Boolean valueSetterParamOptional;
   Boolean offsetPageIncrement;
+  Boolean cursorPagination;
   Object limit;
   LinkedHashMap<String, Object> args;
   int pageStart;
@@ -24,6 +25,7 @@ public class PaginationIterable<T> implements Iterable<T> {
       String valueSetterPath,
       Boolean valueSetterParamOptional,
       Boolean offsetPageIncrement,
+      Boolean cursorPagination,
       Object limit,
       LinkedHashMap<String, Object> args,
       int pageStart) {
@@ -41,6 +43,7 @@ public class PaginationIterable<T> implements Iterable<T> {
     this.valueSetterPath = valueSetterPath.split("\\.");
     this.valueSetterParamOptional = valueSetterParamOptional;
     this.offsetPageIncrement = offsetPageIncrement;
+    this.cursorPagination = cursorPagination;
     this.limit = limit;
     this.args = args;
     this.pageStart = pageStart;

.generator/src/generator/templates/PaginationIterator.j2

@@ -142,7 +142,11 @@ public class PaginationIterator<T> implements Iterator<T> {
       return true;
     }
 
-    if (this.data.size() < convertToInt(this.iterable.limit)) {
+    if (this.iterable.cursorPagination) {
+      if (this.data.size() == 0) {
+        return false;
+      }
+    } else if (this.data.size() < convertToInt(this.iterable.limit)) {
       return false;
     }
 

src/main/java/com/datadog/api/client/PaginationIterable.java

@@ -16,6 +16,7 @@ public class PaginationIterable<T> implements Iterable<T> {
   String[] valueSetterPath;
   Boolean valueSetterParamOptional;
   Boolean offsetPageIncrement;
+  Boolean cursorPagination;
   Object limit;
   LinkedHashMap<String, Object> args;
   int pageStart;
@@ -28,6 +29,7 @@ public PaginationIterable(
       String valueSetterPath,
       Boolean valueSetterParamOptional,
       Boolean offsetPageIncrement,
+      Boolean cursorPagination,
       Object limit,
       LinkedHashMap<String, Object> args,
       int pageStart) {
@@ -45,6 +47,7 @@ public PaginationIterable(
     this.valueSetterPath = valueSetterPath.split("\\.");
     this.valueSetterParamOptional = valueSetterParamOptional;
     this.offsetPageIncrement = offsetPageIncrement;
+    this.cursorPagination = cursorPagination;
     this.limit = limit;
     this.args = args;
     this.pageStart = pageStart;

src/main/java/com/datadog/api/client/PaginationIterator.java

@@ -147,7 +147,11 @@ public boolean hasNext() {
       return true;
     }
 
-    if (this.data.size() < convertToInt(this.iterable.limit)) {
+    if (this.iterable.cursorPagination) {
+      if (this.data.size() == 0) {
+        return false;
+      }
+    } else if (this.data.size() < convertToInt(this.iterable.limit)) {
       return false;
     }
 

src/main/java/com/datadog/api/client/v1/api/DashboardsApi.java

@@ -1543,6 +1543,7 @@ public PaginationIterable<DashboardSummaryDefinition> listDashboardsWithPaginati
             valueSetterPath,
             valueSetterParamOptional,
             true,
+            false,
             limit,
             args,
             0);

src/main/java/com/datadog/api/client/v1/api/MonitorsApi.java

@@ -1329,6 +1329,7 @@ public PaginationIterable<Monitor> listMonitorsWithPagination(
             valueSetterPath,
             valueSetterParamOptional,
             false,
+            false,
             limit,
             args,
             0);

src/main/java/com/datadog/api/client/v1/api/NotebooksApi.java

@@ -690,6 +690,7 @@ public PaginationIterable<NotebooksResponseData> listNotebooksWithPagination(
             valueSetterPath,
             valueSetterParamOptional,
             true,
+            false,
             limit,
             args,
             0);

src/main/java/com/datadog/api/client/v1/api/ServiceLevelObjectiveCorrectionsApi.java

@@ -597,6 +597,7 @@ public PaginationIterable<SLOCorrection> listSLOCorrectionWithPagination(
             valueSetterPath,
             valueSetterParamOptional,
             true,
+            false,
             limit,
             args,
             0);

src/main/java/com/datadog/api/client/v1/api/ServiceLevelObjectivesApi.java

@@ -1445,6 +1445,7 @@ public PaginationIterable<ServiceLevelObjective> listSLOsWithPagination(
             valueSetterPath,
             valueSetterParamOptional,
             true,
+            false,
             limit,
             args,
             0);