Fix spans/logs custom metrics delete operation responses (#1419)

Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>

Author: api-clients-generation-pipeline[bot]

.apigentools-info

@@ -4,13 +4,13 @@
     "spec_versions": {
         "v1": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-04-17 18:07:39.537251",
-            "spec_repo_commit": "25a92e6d"
+            "regenerated": "2023-04-18 17:35:07.161509",
+            "spec_repo_commit": "0c4beb36"
         },
         "v2": {
             "apigentools_version": "1.6.4",
-            "regenerated": "2023-04-17 18:07:39.548748",
-            "spec_repo_commit": "25a92e6d"
+            "regenerated": "2023-04-18 17:35:07.174065",
+            "spec_repo_commit": "0c4beb36"
         }
     }
 }

.generator/schemas/v2/openapi.yaml

@@ -14564,7 +14564,7 @@ paths:
       parameters:
       - $ref: '#/components/parameters/SpansMetricIDParameter'
       responses:
-        '200':
+        '204':
           description: OK
         '403':
           $ref: '#/components/responses/NotAuthorizedResponse'
@@ -18090,7 +18090,7 @@ paths:
       parameters:
       - $ref: '#/components/parameters/MetricID'
       responses:
-        '200':
+        '204':
           description: OK
         '403':
           $ref: '#/components/responses/NotAuthorizedResponse'

tests/v2/cassettes/test_scenarios/test_delete_a_logbased_metric_returns_ok_response.frozen

@@ -1 +1 @@
-2022-05-12T09:52:23.762Z
+2023-04-18T17:27:11.097Z

tests/v2/cassettes/test_scenarios/test_delete_a_logbased_metric_returns_ok_response.yaml

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: '{"data":{"attributes":{"compute":{"aggregation_type":"count"},"filter":{"query":"source:Test-Delete_a_log_based_metric_returns_OK_response-1652349143"}},"id":"Test-Delete_a_log_based_metric_returns_OK_response-1652349143","type":"logs_metrics"}}'
+    body: '{"data":{"attributes":{"compute":{"aggregation_type":"count"},"filter":{"query":"source:Test-Delete_a_log_based_metric_returns_OK_response-1681838831"}},"id":"Test-Delete_a_log_based_metric_returns_OK_response-1681838831","type":"logs_metrics"}}'
     headers:
       accept:
       - application/json
@@ -10,7 +10,9 @@ interactions:
     uri: https://api.datadoghq.com/api/v2/logs/config/metrics
   response:
     body:
-      string: '{"data":{"attributes":{"filter":{"query":"source:Test-Delete_a_log_based_metric_returns_OK_response-1652349143"},"group_by":[],"compute":{"aggregation_type":"count"}},"type":"logs_metrics","id":"Test_Delete_a_log_based_metric_returns_OK_response_1652349143"}}'
+      string: '{"data":{"id":"Test_Delete_a_log_based_metric_returns_OK_response_1681838831","attributes":{"filter":{"query":"source:Test-Delete_a_log_based_metric_returns_OK_response-1681838831"},"group_by":[],"compute":{"aggregation_type":"count"}},"type":"logs_metrics"}}
+
+        '
     headers:
       content-type:
       - application/json
@@ -23,27 +25,29 @@ interactions:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1652349143
+    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1681838831
   response:
     body:
-      string: '{}'
+      string: ''
     headers:
       content-type:
-      - application/json
+      - text/html; charset=utf-8
     status:
-      code: 200
-      message: OK
+      code: 204
+      message: No Content
 - request:
     body: null
     headers:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1652349143
+    uri: https://api.datadoghq.com/api/v2/logs/config/metrics/Test_Delete_a_log_based_metric_returns_OK_response_1681838831
   response:
     body:
-      string: '{"errors":["not_found(Metric with name ''Test_Delete_a_log_based_metric_returns_OK_response_1652349143''
-        not found)"]}'
+      string: '{"errors":["not_found(Metric with name ''Test_Delete_a_log_based_metric_returns_OK_response_1681838831''
+        not found)"]}
+
+        '
     headers:
       content-type:
       - application/json

tests/v2/cassettes/test_scenarios/test_delete_a_spanbased_metric_returns_ok_response.frozen

@@ -1 +1 @@
-2023-03-28T14:55:25.279Z
+2023-04-18T17:28:08.946Z

tests/v2/cassettes/test_scenarios/test_delete_a_spanbased_metric_returns_ok_response.yaml

@@ -1,6 +1,6 @@
 interactions:
 - request:
-    body: '{"data":{"attributes":{"compute":{"aggregation_type":"distribution","include_percentiles":false,"path":"@duration"},"filter":{"query":"source:Test-Delete_a_span_based_metric_returns_OK_response-1680015325"},"group_by":[{"path":"resource_name","tag_name":"resource_name"}]},"id":"Test-Delete_a_span_based_metric_returns_OK_response-1680015325","type":"spans_metrics"}}'
+    body: '{"data":{"attributes":{"compute":{"aggregation_type":"distribution","include_percentiles":false,"path":"@duration"},"filter":{"query":"source:Test-Delete_a_span_based_metric_returns_OK_response-1681838888"},"group_by":[{"path":"resource_name","tag_name":"resource_name"}]},"id":"Test-Delete_a_span_based_metric_returns_OK_response-1681838888","type":"spans_metrics"}}'
     headers:
       accept:
       - application/json
@@ -10,7 +10,7 @@ interactions:
     uri: https://api.datadoghq.com/api/v2/apm/config/metrics
   response:
     body:
-      string: '{"data":{"id":"Test_Delete_a_span_based_metric_returns_OK_response_1680015325","attributes":{"filter":{"query":"source:Test-Delete_a_span_based_metric_returns_OK_response-1680015325"},"group_by":[{"path":"resource_name","tag_name":"resource_name"}],"compute":{"aggregation_type":"distribution","path":"@duration","include_percentiles":false}},"type":"spans_metrics"}}
+      string: '{"data":{"id":"Test_Delete_a_span_based_metric_returns_OK_response_1681838888","attributes":{"filter":{"query":"source:Test-Delete_a_span_based_metric_returns_OK_response-1681838888"},"group_by":[{"path":"resource_name","tag_name":"resource_name"}],"compute":{"aggregation_type":"distribution","path":"@duration","include_percentiles":false}},"type":"spans_metrics"}}
 
         '
     headers:
@@ -25,28 +25,26 @@ interactions:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1680015325
+    uri: https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1681838888
   response:
     body:
-      string: '{}
-
-        '
+      string: ''
     headers:
       content-type:
-      - application/json
+      - text/html; charset=utf-8
     status:
-      code: 200
-      message: OK
+      code: 204
+      message: No Content
 - request:
     body: null
     headers:
       accept:
       - '*/*'
     method: DELETE
-    uri: https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1680015325
+    uri: https://api.datadoghq.com/api/v2/apm/config/metrics/Test_Delete_a_span_based_metric_returns_OK_response_1681838888
   response:
     body:
-      string: '{"errors":["not_found(Metric with name ''Test_Delete_a_span_based_metric_returns_OK_response_1680015325''
+      string: '{"errors":["not_found(Metric with name ''Test_Delete_a_span_based_metric_returns_OK_response_1681838888''
         not found)"]}
 
         '

tests/v2/features/logs_metrics.feature

@@ -47,7 +47,7 @@ Feature: Logs Metrics
     And new "DeleteLogsMetric" request
     And request contains "metric_id" parameter from "logs_metric.data.id"
     When the request is sent
-    Then the response status is 200 OK
+    Then the response status is 204 OK
 
   @generated @skip @team:DataDog/logs-backend
   Scenario: Get a log-based metric returns "Not Found" response

tests/v2/features/spans_metrics.feature

@@ -46,7 +46,7 @@ Feature: Spans Metrics
     And new "DeleteSpansMetric" request
     And request contains "metric_id" parameter from "spans_metric.data.id"
     When the request is sent
-    Then the response status is 200 OK
+    Then the response status is 204 OK
 
   @generated @skip @team:DataDog/apm
   Scenario: Get a span-based metric returns "Not Found" response