Skip to content

Commit b43a9d0

Browse files
authored
Merge pull request #3421 from DataDog/datadog-api-spec/generated/5468
Security Monitoring - expand learningDuration and forgetAfter to support up to 30 days
2 parents 77ed302 + 350aa73 commit b43a9d0

7 files changed

Lines changed: 23 additions & 166 deletions

.generator/schemas/v2/openapi.yaml

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -64576,35 +64576,17 @@ components:
6457664576
type: object
6457764577
SecurityMonitoringRuleNewValueOptionsForgetAfter:
6457864578
description: The duration in days after which a learned value is forgotten.
64579-
enum:
64580-
- 1
64581-
- 2
64582-
- 7
64583-
- 14
64584-
- 21
64585-
- 28
6458664579
format: int32
64580+
maximum: 30
64581+
minimum: 1
6458764582
type: integer
64588-
x-enum-varnames:
64589-
- ONE_DAY
64590-
- TWO_DAYS
64591-
- ONE_WEEK
64592-
- TWO_WEEKS
64593-
- THREE_WEEKS
64594-
- FOUR_WEEKS
6459564583
SecurityMonitoringRuleNewValueOptionsLearningDuration:
6459664584
default: 0
6459764585
description: "The duration in days during which values are learned, and after which signals will be generated for values that\nweren't learned. If set to 0, a signal will be generated for all new values after the first value is learned."
64598-
enum:
64599-
- 0
64600-
- 1
64601-
- 7
6460264586
format: int32
64587+
maximum: 30
64588+
minimum: 0
6460364589
type: integer
64604-
x-enum-varnames:
64605-
- ZERO_DAYS
64606-
- ONE_DAY
64607-
- SEVEN_DAYS
6460864590
SecurityMonitoringRuleNewValueOptionsLearningMethod:
6460964591
default: duration
6461064592
description: The learning method used to determine when signals should be generated for values that weren't learned.

docs/datadog_api_client.v2.model.rst

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28718,20 +28718,6 @@ datadog\_api\_client.v2.model.security\_monitoring\_rule\_new\_value\_options mo
2871828718
:members:
2871928719
:show-inheritance:
2872028720

28721-
datadog\_api\_client.v2.model.security\_monitoring\_rule\_new\_value\_options\_forget\_after module
28722-
---------------------------------------------------------------------------------------------------
28723-
28724-
.. automodule:: datadog_api_client.v2.model.security_monitoring_rule_new_value_options_forget_after
28725-
:members:
28726-
:show-inheritance:
28727-
28728-
datadog\_api\_client.v2.model.security\_monitoring\_rule\_new\_value\_options\_learning\_duration module
28729-
--------------------------------------------------------------------------------------------------------
28730-
28731-
.. automodule:: datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_duration
28732-
:members:
28733-
:show-inheritance:
28734-
2873528721
datadog\_api\_client.v2.model.security\_monitoring\_rule\_new\_value\_options\_learning\_method module
2873628722
------------------------------------------------------------------------------------------------------
2873728723

examples/v2/security-monitoring/ValidateSecurityMonitoringRule_2609327779.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,6 @@
1515
SecurityMonitoringRuleMaxSignalDuration,
1616
)
1717
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options import SecurityMonitoringRuleNewValueOptions
18-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_forget_after import (
19-
SecurityMonitoringRuleNewValueOptionsForgetAfter,
20-
)
21-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_duration import (
22-
SecurityMonitoringRuleNewValueOptionsLearningDuration,
23-
)
2418
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_method import (
2519
SecurityMonitoringRuleNewValueOptionsLearningMethod,
2620
)
@@ -55,9 +49,9 @@
5549
max_signal_duration=SecurityMonitoringRuleMaxSignalDuration.TEN_MINUTES,
5650
detection_method=SecurityMonitoringRuleDetectionMethod.NEW_VALUE,
5751
new_value_options=SecurityMonitoringRuleNewValueOptions(
58-
forget_after=SecurityMonitoringRuleNewValueOptionsForgetAfter.ONE_WEEK,
52+
forget_after=7,
5953
instantaneous_baseline=True,
60-
learning_duration=SecurityMonitoringRuleNewValueOptionsLearningDuration.ONE_DAY,
54+
learning_duration=1,
6155
learning_threshold=SecurityMonitoringRuleNewValueOptionsLearningThreshold.ZERO_OCCURRENCES,
6256
learning_method=SecurityMonitoringRuleNewValueOptionsLearningMethod.DURATION,
6357
),

src/datadog_api_client/v2/model/security_monitoring_rule_new_value_options.py

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414

1515

1616
if TYPE_CHECKING:
17-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_forget_after import (
18-
SecurityMonitoringRuleNewValueOptionsForgetAfter,
19-
)
20-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_duration import (
21-
SecurityMonitoringRuleNewValueOptionsLearningDuration,
22-
)
2317
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_method import (
2418
SecurityMonitoringRuleNewValueOptionsLearningMethod,
2519
)
@@ -29,14 +23,19 @@
2923

3024

3125
class SecurityMonitoringRuleNewValueOptions(ModelNormal):
26+
validations = {
27+
"forget_after": {
28+
"inclusive_maximum": 30,
29+
"inclusive_minimum": 1,
30+
},
31+
"learning_duration": {
32+
"inclusive_maximum": 30,
33+
"inclusive_minimum": 0,
34+
},
35+
}
36+
3237
@cached_property
3338
def openapi_types(_):
34-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_forget_after import (
35-
SecurityMonitoringRuleNewValueOptionsForgetAfter,
36-
)
37-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_duration import (
38-
SecurityMonitoringRuleNewValueOptionsLearningDuration,
39-
)
4039
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_method import (
4140
SecurityMonitoringRuleNewValueOptionsLearningMethod,
4241
)
@@ -45,9 +44,9 @@ def openapi_types(_):
4544
)
4645

4746
return {
48-
"forget_after": (SecurityMonitoringRuleNewValueOptionsForgetAfter,),
47+
"forget_after": (int,),
4948
"instantaneous_baseline": (bool,),
50-
"learning_duration": (SecurityMonitoringRuleNewValueOptionsLearningDuration,),
49+
"learning_duration": (int,),
5150
"learning_method": (SecurityMonitoringRuleNewValueOptionsLearningMethod,),
5251
"learning_threshold": (SecurityMonitoringRuleNewValueOptionsLearningThreshold,),
5352
}
@@ -62,9 +61,9 @@ def openapi_types(_):
6261

6362
def __init__(
6463
self_,
65-
forget_after: Union[SecurityMonitoringRuleNewValueOptionsForgetAfter, UnsetType] = unset,
64+
forget_after: Union[int, UnsetType] = unset,
6665
instantaneous_baseline: Union[bool, UnsetType] = unset,
67-
learning_duration: Union[SecurityMonitoringRuleNewValueOptionsLearningDuration, UnsetType] = unset,
66+
learning_duration: Union[int, UnsetType] = unset,
6867
learning_method: Union[SecurityMonitoringRuleNewValueOptionsLearningMethod, UnsetType] = unset,
6968
learning_threshold: Union[SecurityMonitoringRuleNewValueOptionsLearningThreshold, UnsetType] = unset,
7069
**kwargs,
@@ -73,14 +72,14 @@ def __init__(
7372
Options on new value detection method.
7473
7574
:param forget_after: The duration in days after which a learned value is forgotten.
76-
:type forget_after: SecurityMonitoringRuleNewValueOptionsForgetAfter, optional
75+
:type forget_after: int, optional
7776
7877
:param instantaneous_baseline: When set to true, Datadog uses previous values that fall within the defined learning window to construct the baseline, enabling the system to establish an accurate baseline more rapidly rather than relying solely on gradual learning over time.
7978
:type instantaneous_baseline: bool, optional
8079
8180
:param learning_duration: The duration in days during which values are learned, and after which signals will be generated for values that
8281
weren't learned. If set to 0, a signal will be generated for all new values after the first value is learned.
83-
:type learning_duration: SecurityMonitoringRuleNewValueOptionsLearningDuration, optional
82+
:type learning_duration: int, optional
8483
8584
:param learning_method: The learning method used to determine when signals should be generated for values that weren't learned.
8685
:type learning_method: SecurityMonitoringRuleNewValueOptionsLearningMethod, optional

src/datadog_api_client/v2/model/security_monitoring_rule_new_value_options_forget_after.py

Lines changed: 0 additions & 50 deletions
This file was deleted.

src/datadog_api_client/v2/model/security_monitoring_rule_new_value_options_learning_duration.py

Lines changed: 0 additions & 46 deletions
This file was deleted.

src/datadog_api_client/v2/models/__init__.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5807,12 +5807,6 @@
58075807
SecurityMonitoringRuleMaxSignalDuration,
58085808
)
58095809
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options import SecurityMonitoringRuleNewValueOptions
5810-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_forget_after import (
5811-
SecurityMonitoringRuleNewValueOptionsForgetAfter,
5812-
)
5813-
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_duration import (
5814-
SecurityMonitoringRuleNewValueOptionsLearningDuration,
5815-
)
58165810
from datadog_api_client.v2.model.security_monitoring_rule_new_value_options_learning_method import (
58175811
SecurityMonitoringRuleNewValueOptionsLearningMethod,
58185812
)
@@ -11615,8 +11609,6 @@
1161511609
"SecurityMonitoringRuleKeepAlive",
1161611610
"SecurityMonitoringRuleMaxSignalDuration",
1161711611
"SecurityMonitoringRuleNewValueOptions",
11618-
"SecurityMonitoringRuleNewValueOptionsForgetAfter",
11619-
"SecurityMonitoringRuleNewValueOptionsLearningDuration",
1162011612
"SecurityMonitoringRuleNewValueOptionsLearningMethod",
1162111613
"SecurityMonitoringRuleNewValueOptionsLearningThreshold",
1162211614
"SecurityMonitoringRuleOptions",

0 commit comments

Comments
 (0)