Skip to content

fix: keep workspace ls sizes schema-safe#612

Merged
chubes4 merged 1 commit into
mainfrom
fix/workspace-ls-size-contract
Jun 8, 2026
Merged

fix: keep workspace ls sizes schema-safe#612
chubes4 merged 1 commit into
mainfrom
fix/workspace-ls-size-contract

Conversation

@chubes4

@chubes4 chubes4 commented Jun 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Always include an integer size field for local workspace-ls entries.
  • Report directories and non-regular entries as size 0; report files with integer byte size.
  • Add a focused smoke for the local directory listing contract.

Evidence

  • SSI lab retry ssi-322-script-artifacts-retry-evidence-5 hit datamachine-code/workspace-ls output validation failures: output[entries][8][size] is not of type integer.

Testing

  • php -l inc/Workspace/WorkspaceReader.php
  • php -l tests/smoke-workspace-list-directory.php
  • php tests/smoke-workspace-list-directory.php
  • php tests/smoke-workspace-grep.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Drafted the schema-safe size normalization and focused smoke coverage; Chris remains responsible for review and merge.

@chubes4 chubes4 merged commit 1506368 into main Jun 8, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant