Skip to content

fix: normalize mounted workspace writes #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 2 commits into from
Jun 9, 2026
+36 −13
Merged

fix: normalize mounted workspace writes #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7454c9b
fix: normalize mounted workspace writes
chubes4 Jun 9, 2026
b357e37
style: align workspace ability schemas
chubes4 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions inc/Abilities/WorkspaceAbilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,17 @@ private function registerAbilities(): void {
'output_schema' => array(
'type' => 'object',
'properties' => array(
'success' => array( 'type' => 'boolean' ),
'name' => array( 'type' => 'string' ),
'repo' => array( 'type' => 'string' ),
'is_worktree' => array( 'type' => 'boolean' ),
'path' => array( 'type' => 'string' ),
'success' => array( 'type' => 'boolean' ),
'name' => array( 'type' => 'string' ),
'repo' => array( 'type' => 'string' ),
'is_worktree' => array( 'type' => 'boolean' ),
'path' => array( 'type' => 'string' ),
// Nullable: detached HEAD has no branch; local-only repos
// have no remote; freshly-init'd repos have no commit yet.
'branch' => array( 'type' => array( 'string', 'null' ) ),
'remote' => array( 'type' => array( 'string', 'null' ) ),
'commit' => array( 'type' => array( 'string', 'null' ) ),
'dirty' => array( 'type' => 'integer' ),
'branch' => array( 'type' => array( 'string', 'null' ) ),
'remote' => array( 'type' => array( 'string', 'null' ) ),
'commit' => array( 'type' => array( 'string', 'null' ) ),
'dirty' => array( 'type' => 'integer' ),
'primary_freshness' => self::primaryFreshnessSchema(),
),
),
Expand Down Expand Up @@ -390,19 +390,19 @@ private function registerAbilities(): void {
'input_schema' => array(
'type' => 'object',
'properties' => array(
'url' => array(
'url' => array(
'type' => 'string',
'description' => 'Git repository URL to clone.',
),
'name' => array(
'name' => array(
'type' => 'string',
'description' => 'Directory name override (derived from URL if omitted).',
),
'full' => array(
'full' => array(
'type' => 'boolean',
'description' => 'Disable the default blobless partial clone for remote repositories.',
),
'auth_token_env' => array(
'auth_token_env' => array(
'type' => 'string',
'description' => 'Optional environment variable name containing a bearer token for HTTPS clone authentication.',
),
Expand Down Expand Up @@ -2665,6 +2665,7 @@ public static function removeRepo( array $input ): array|\WP_Error {
* @return array Result.
*/
public static function writeFile( array $input ): array|\WP_Error {
$input = self::normalize_mounted_workspace_path_input($input, array( 'repo' ));
if ( RemoteWorkspaceBackend::should_handle() ) {
$result = ( new RemoteWorkspaceBackend() )->write_file(
$input['repo'] ?? '',
Expand Down
22 changes: 22 additions & 0 deletions tests/smoke-workspace-alias-tools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
$GLOBALS['dmc_workspace_alias_ability'] = null;
$GLOBALS['dmc_workspace_alias_registered_abilities'] = array();
$GLOBALS['dmc_workspace_alias_remote_edit_input'] = array();
$GLOBALS['dmc_workspace_alias_remote_write_input'] = array();

function add_filter( string $tag, callable $callback, int $priority = 10, int $accepted_args = 1 ): void
{
Expand Down Expand Up @@ -127,6 +128,16 @@ public function edit_file( string $handle, string $path, string $old_string, str
'replacements' => 1,
);
}

public function write_file( string $handle, string $path, string $content ): array
{
$GLOBALS['dmc_workspace_alias_remote_write_input'] = compact('handle', 'path', 'content');
return array(
'success' => true,
'name' => $handle,
'path' => $path,
);
}
}
}

Expand Down Expand Up @@ -273,6 +284,17 @@ public function execute( array $input ): array
$assert('workspace_edit ability maps old alias to old_string', 'npm install --silent' === ( $GLOBALS['dmc_workspace_alias_remote_edit_input']['old_string'] ?? '' ));
$assert('workspace_edit ability maps new alias to new_string', 'npm install --legacy-peer-deps' === ( $GLOBALS['dmc_workspace_alias_remote_edit_input']['new_string'] ?? '' ));

$ability_mounted_write = \DataMachineCode\Abilities\WorkspaceAbilities::writeFile(
array(
'path' => '/workspace/example-plugin/wordpress/scripts/build/generated.sh',
'content' => '#!/bin/sh',
)
);
$assert('workspace_write ability accepts mounted absolute path', ! is_wp_error($ability_mounted_write) && true === ( $ability_mounted_write['success'] ?? false ));
$assert('workspace_write ability infers repo from mounted path', 'example-plugin' === ( $GLOBALS['dmc_workspace_alias_remote_write_input']['handle'] ?? '' ));
$assert('workspace_write ability converts mounted path to relative path', 'wordpress/scripts/build/generated.sh' === ( $GLOBALS['dmc_workspace_alias_remote_write_input']['path'] ?? '' ));
$assert('workspace_write ability preserves content', '#!/bin/sh' === ( $GLOBALS['dmc_workspace_alias_remote_write_input']['content'] ?? '' ));

$unsupported_alias = \DataMachineCode\Abilities\WorkspaceAbilities::editFile(
array(
'repo' => 'example-plugin',
Expand Down
Loading