fix: Appease mypy --strict on perf branch

CI runs ``mypy --strict .`` which covers the new ``benchmarks/`` dir and
is stricter than the default invocation. Fixes:

- ``flagsmith/mappers.py::_variant_priority`` — annotate the dict lookup
  so it doesn't leak ``Any`` through the ``int`` return type.
- ``benchmarks/env.py::build_environment`` — annotate the ``json.load``
  result so the ``dict[str, Any]`` return type is satisfied.
- ``benchmarks/bench.py::_make_client`` — drop the redundant
  ``_Flagsmith__evaluation_context`` pre-seed (the property setter sets
  the backing field itself) and cast the synthetic env dict to
  ``EnvironmentModel`` at the engine boundary.

beep boop

Author: khvn26

benchmarks/bench.py

@@ -19,19 +19,26 @@
 import pstats
 import statistics
 import time
-from typing import Callable
+from typing import Callable, cast
 
 from benchmarks.env import build_environment
 from flagsmith import Flagsmith
+from flagsmith.api.types import EnvironmentModel
 from flagsmith.mappers import map_environment_document_to_context
 
 
 def _make_client(n_features: int, with_multivariate: int = 0) -> Flagsmith:
-    env_doc = build_environment(
-        n_features=n_features,
-        with_multivariate=with_multivariate,
+    env_doc = cast(
+        EnvironmentModel,
+        build_environment(
+            n_features=n_features,
+            with_multivariate=with_multivariate,
+        ),
     )
     # Build a local-eval client without hitting the network / starting polling.
+    # The property setter on ``_evaluation_context`` initialises all the
+    # derived caches we need; everything else below is what ``Flagsmith.__init__``
+    # would otherwise set during its real construction path.
     client = Flagsmith.__new__(Flagsmith)
     client.offline_mode = False
     client.enable_local_evaluation = True
@@ -40,10 +47,6 @@ def _make_client(n_features: int, with_multivariate: int = 0) -> Flagsmith:
     client.enable_realtime_updates = False
     client._analytics_processor = None
     client._pipeline_analytics_processor = None
-    client._Flagsmith__evaluation_context = None
-    client._environment_context_without_segments = None
-    client._environment_flags_cache = None
-    client._identity_flags_match_environment = False
     client._environment_updated_at = None
     client._evaluation_context = map_environment_document_to_context(env_doc)
     return client

benchmarks/env.py

@@ -21,7 +21,7 @@ def build_environment(
     with_multivariate: int = 0,
 ) -> dict[str, typing.Any]:
     with open(TEMPLATE_PATH) as f:
-        env = json.load(f)
+        env: dict[str, typing.Any] = json.load(f)
 
     # Base feature state to clone.
     base_fs = copy.deepcopy(env["feature_states"][0])

flagsmith/mappers.py

@@ -278,4 +278,5 @@ def _map_environment_document_feature_states_to_feature_contexts(
 
 
 def _variant_priority(variant: typing.Mapping[str, typing.Any]) -> int:
-    return variant["priority"]
+    priority: int = variant["priority"]
+    return priority