From 48cfbab9c26469c02ca1057a1e2d13e91d281e35 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 28 May 2025 13:04:26 +0000 Subject: [PATCH 1/2] chore(deps): bump org.jetbrains.kotlin.android from 1.9.25 to 2.1.21 Bumps [org.jetbrains.kotlin.android](https://github.com/JetBrains/kotlin) from 1.9.25 to 2.1.21. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](https://github.com/JetBrains/kotlin/compare/v1.9.25...v2.1.21) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.android dependency-version: 2.1.21 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- gradle/libs.versions.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 57731f3a..5003957d 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -1,6 +1,6 @@ [versions] #jetbrains -kotlin = "1.9.25" +kotlin = "2.1.21" #Detekt detekt = "1.23.8" #Androidx From e867445ebc2243f7315748b34f37ebd94a7a4ecd Mon Sep 17 00:00:00 2001 From: Naveen Singh Date: Wed, 28 May 2025 18:44:09 +0530 Subject: [PATCH 2/2] refactor: move `ONE_MEGA_PIXEL` constant to top-level --- .../main/kotlin/org/fossify/camera/models/VideoQuality.kt | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/kotlin/org/fossify/camera/models/VideoQuality.kt b/app/src/main/kotlin/org/fossify/camera/models/VideoQuality.kt index 1497ed51..dfad75e5 100644 --- a/app/src/main/kotlin/org/fossify/camera/models/VideoQuality.kt +++ b/app/src/main/kotlin/org/fossify/camera/models/VideoQuality.kt @@ -5,6 +5,8 @@ import androidx.annotation.DrawableRes import androidx.annotation.IdRes import org.fossify.camera.R +private const val ONE_MEGA_PIXEL = 1000000 + enum class VideoQuality(val width: Int, val height: Int) { UHD(3840, 2160), FHD(1920, 1080), @@ -14,7 +16,7 @@ enum class VideoQuality(val width: Int, val height: Int) { val pixels: Int = width * height val megaPixels: String = - String.format("%.1f", (width * height.toFloat()) / VideoQuality.ONE_MEGA_PIXEL) + String.format("%.1f", (width * height.toFloat()) / ONE_MEGA_PIXEL) val ratio = width / height.toFloat() @@ -74,8 +76,4 @@ enum class VideoQuality(val width: Int, val height: Int) { fun toResolutionOption(): ResolutionOption { return ResolutionOption(buttonViewId = getButtonId(), imageDrawableResId = getImageResId()) } - - companion object { - private const val ONE_MEGA_PIXEL = 1000000 - } }