Change h5repack low library bound to H5F_LIBVER_V18#6352
Open
ajelenak wants to merge 12 commits into
Open
Conversation
ajelenak
requested review from
bmribler,
brtnfld,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
bmribler
requested changes
Apr 6, 2026
github-project-automation
Bot
moved this from To be triaged
to In progress
in HDF5 - TRIAGE & TRACK
hyoklee
added
the
Component - Tools
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hyoklee
previously approved these changes
May 4, 2026
bmribler
previously approved these changes
May 11, 2026
…ygwin (HDFGroup#6396) The earlier block (line 164-167) adds _GNU_SOURCE to CMAKE_REQUIRED_DEFINITIONS and via add_definitions for MinGW/Cygwin. However, the later 'MinGW and Cygwin' block overwrites CMAKE_REQUIRED_DEFINITIONS using CURRENT_TEST_DEFINITIONS (which is undefined/empty), discarding _GNU_SOURCE. This causes subsequent configure checks like vasprintf to not see _GNU_SOURCE in their test definitions. Use CMAKE_REQUIRED_DEFINITIONS instead of CURRENT_TEST_DEFINITIONS to append to the existing definitions (which already include _GNU_SOURCE) rather than replacing them. Fixes HDFGroup#5885
…#6406) Both ninja and curl are pre-installed on the GitHub macOS runners, causing noisy "already installed" warnings. Drop those brew steps entirely (or just remove ninja/curl where other packages like graphviz or libaec are still needed).
…#6404) Make sure that everything is clean before copying files to a directory.
…DFGroup#6408) Before creating the namespaced `hdf5::<name>` alias, query ALIASED_TARGET so we point the new alias at the real target. When the target is not an alias the behaviour is unchanged. config/HDF5Use{ZLIB,Libaec}.cmake: resolve ALIASED_TARGET before re-aliasing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6348.