Skip to content

Improve AnisotropicDiffusionLBR tests #6283

@hjmjohnson

Description

@hjmjohnson

The AnisotropicDiffusionLBR module was ingested into ITK from the (now archived) ITKAnisotropicDiffusionLBR remote module. This issue tracks, in ITK proper, the test-improvement work originally filed as InsightSoftwareConsortium/ITKAnisotropicDiffusionLBR#26 by @jhlegarreta (2018-11-09).

The existing tests should be improved:

  • The files CoherenceEnhancingDiffusionCommandLine.h and LinearAnisotropicDiffusionCommandLine.h are not actually needed for the module functionality, and only serve for testing purposes. They should be moved into the test directory, and tests should be refactored to follow ITK testing conventions (i.e. their contents should be in a *.cxx implementation file).
  • The ITK testing macros should be used (e.g. ITK_TRY_EXPECT_NO_EXCEPTION, ITK_EXERCISE_BASIC_OBJECT_METHODS, etc.) to avoid boilerplate code.
  • The tests should run as long as possible and return the status code at the end (i.e. use a testStatus and change its value as tests fail: requires changing the test design).
  • Improve the argument check message.
  • Remove the unnecessary message prints.
  • The coding style should conform to the ITK coding style (Software Guide, Appendix Three).

Original report: InsightSoftwareConsortium/ITKAnisotropicDiffusionLBR#26 (archived repository). Credit: @jhlegarreta.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions