Skip to content

Commit 07d7233

Browse files
committed
Resolve a trace inconsistency warning
1 parent 667132f commit 07d7233

2 files changed

Lines changed: 43 additions & 15 deletions

File tree

cardano-node/src/Cardano/Node/Tracing/Consistency.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,9 @@ import qualified Data.Text as T
101101
import qualified Network.Mux as Mux
102102
import qualified Network.Socket as Socket
103103

104-
import LeiosDemoTypes (LeiosPoint, LeiosEb, LeiosTx, TraceLeiosKernel, TraceLeiosPeer)
105104
import LeiosDemoOnlyTestFetch (LeiosFetch)
106105
import LeiosDemoOnlyTestNotify (LeiosNotify)
106+
import LeiosDemoTypes (LeiosEb, LeiosPoint, LeiosTx, TraceLeiosKernel, TraceLeiosPeer)
107107

108108
-- | Check the configuration in the given file.
109109
-- If there is no configuration in the file check the standard configuration
@@ -210,9 +210,9 @@ getAllNamespaces =
210210
(allNamespaces :: [Namespace (Jumping.TraceEventCsj peer blk)])
211211
dbfNS = map (nsGetTuple . nsReplacePrefix ["Consensus", "DevotedBlockFetch"])
212212
(allNamespaces :: [Namespace (Jumping.TraceEventDbf peer)])
213-
leiosKernelNS = map (nsGetTuple . nsReplacePrefix ["Consensus", "LeiosKernel"])
213+
leiosKernelNS = map (nsGetTuple . nsReplacePrefix ["Consensus", "Leios"])
214214
(allNamespaces :: [Namespace TraceLeiosKernel])
215-
leiosPeerNS = map (nsGetTuple . nsReplacePrefix ["Consensus", "LeiosPeer"])
215+
leiosPeerNS = map (nsGetTuple . nsReplacePrefix ["Consensus", "Leios"])
216216
(allNamespaces :: [Namespace (BlockFetch.TraceLabelPeer remotePeer TraceLeiosPeer)])
217217
-- Node to client
218218
keepAliveClientNS = map (nsGetTuple . nsReplacePrefix ["Net"])

cardano-node/src/Cardano/Node/Tracing/Tracers/Consensus.hs

Lines changed: 40 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ import Data.Time (NominalDiffTime)
8585
import Data.Word (Word32, Word64)
8686
import Network.TypedProtocol.Core
8787

88-
import LeiosDemoTypes (TraceLeiosKernel (..), TraceLeiosPeer (TraceLeiosPeerDbException),
89-
leiosEbTxs, traceLeiosKernelToObject, traceLeiosPeerToObject)
88+
import LeiosDemoTypes (TraceLeiosKernel (..), TraceLeiosPeer (..), leiosEbTxs,
89+
traceLeiosKernelToObject, traceLeiosPeerToObject)
9090

9191
instance (LogFormatting adr, Show adr) => LogFormatting (ConnectionId adr) where
9292
forMachine _dtal (ConnectionId local' remote) =
@@ -2302,23 +2302,51 @@ instance LogFormatting TraceLeiosKernel where
23022302
asMetrics _ = []
23032303

23042304
instance MetaTrace TraceLeiosKernel where
2305-
namespaceFor _ = Namespace [] []
2306-
2307-
severityFor _ (Just TraceLeiosDbException{}) = Just Error
2308-
severityFor _ _ = Just Debug
2305+
severityFor _ = \case
2306+
Just TraceLeiosDbException{} -> Just Error
2307+
_ -> Just Debug
23092308

23102309
documentFor _ = Nothing
2311-
allNamespaces = [ Namespace [] [] ]
2310+
2311+
namespaceFor t = Namespace [] . pure $ case t of
2312+
MkTraceLeiosKernel{} -> "KernelMsg"
2313+
TraceLeiosBlockAcquired{} -> "BlockAcquired"
2314+
TraceLeiosBlockPointMissing{} -> "BlockPointMissing"
2315+
TraceLeiosBlockTxsAcquired{} -> "BlockTxsAcquired"
2316+
TraceLeiosBlockForged{} -> "BlockForged"
2317+
TraceLeiosBlockStored{} -> "BlockStored"
2318+
TraceLeiosDbException{} -> "DbException"
2319+
2320+
allNamespaces =
2321+
map
2322+
(Namespace [] . pure)
2323+
[ "KernelMsg"
2324+
, "BlockAcquired"
2325+
, "BlockPointMissing"
2326+
, "BlockTxsAcquired"
2327+
, "BlockForged"
2328+
, "BlockStored"
2329+
, "DbException"
2330+
]
23122331

23132332
instance LogFormatting TraceLeiosPeer where
23142333
forHuman = showT
23152334
forMachine _dtal = traceLeiosPeerToObject
23162335

23172336
instance MetaTrace TraceLeiosPeer where
2318-
namespaceFor _ = Namespace [] []
2319-
2320-
severityFor _ (Just TraceLeiosPeerDbException{}) = Just Error
2321-
severityFor _ _ = Just Debug
2337+
severityFor _ = \case
2338+
Just TraceLeiosPeerDbException{} -> Just Error
2339+
_ -> Just Debug
23222340

23232341
documentFor _ = Nothing
2324-
allNamespaces = [ Namespace [] [] ]
2342+
2343+
namespaceFor t = Namespace [] . pure $ case t of
2344+
MkTraceLeiosPeer{} -> "PeerMsg"
2345+
TraceLeiosPeerDbException{} -> "DbException"
2346+
2347+
allNamespaces =
2348+
map
2349+
(Namespace [] . pure)
2350+
[ "PeerMsg"
2351+
, "DbException"
2352+
]

0 commit comments

Comments
 (0)