Skip to content

Commit d599489

Browse files
committed
cleanup constructors
1 parent 7a7f104 commit d599489

2 files changed

Lines changed: 25 additions & 53 deletions

File tree

common-tools/clara-io/src/main/java/org/jlab/io/clara/Clas12Writer.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import java.io.File;
44
import java.nio.file.Path;
5+
import java.util.List;
56
import java.util.TreeMap;
67
import java.util.TreeSet;
78
import org.jlab.analysis.postprocess.Processor;
@@ -145,9 +146,9 @@ private Event getUnixEvent(Bank config) {
145146
*/
146147
private void postprocess() {
147148
int d = conman.getConstants(getRunNumber(), "/runcontrol/helicity").getIntValue("delay",0,0,0);
148-
HelicitySequenceDelayed h = new HelicitySequenceDelayed(d);
149-
h.addStream(helicities);
150-
Processor p = new Processor(fullSchema, h, scalers);
149+
HelicitySequenceDelayed helicity = new HelicitySequenceDelayed(d);
150+
helicity.addStream(helicities);
151+
Processor p = new Processor(List.of(filename), fullSchema, helicity, scalers);
151152
HipoReader r = new HipoReader();
152153
r.open(filename);
153154
Event e = new Event();

common-tools/clas-analysis/src/main/java/org/jlab/analysis/postprocess/Processor.java

Lines changed: 21 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
package org.jlab.analysis.postprocess;
22

33
import java.io.File;
4-
import java.nio.file.FileSystems;
5-
import java.nio.file.PathMatcher;
6-
import java.util.ArrayList;
7-
import java.util.Arrays;
84
import java.util.HashMap;
95
import java.util.List;
106
import java.util.Map;
@@ -47,55 +43,30 @@ public class Processor {
4743
private HelicitySequenceDelayed helicitySequence = null;
4844
private TreeMap<Integer,Integer> eventUnix = null;
4945

50-
public Processor(File file, boolean restream, boolean rebuild) {
51-
configure(Arrays.asList(file.getAbsolutePath()), restream, rebuild);
52-
}
53-
54-
public Processor(String dir, boolean restream, boolean rebuild) {
55-
configure(findPreloadFiles(dir,DEF_PRELOAD_GLOB), restream, rebuild);
56-
}
57-
58-
public Processor(String dir, String glob, boolean restream, boolean rebuild) {
59-
configure(findPreloadFiles(dir,glob), restream, rebuild);
60-
}
61-
6246
public Processor(List<String> files, boolean restream, boolean rebuild) {
63-
configure(files, restream, rebuild);
64-
}
65-
66-
private void configure(List<String> preloadFiles, boolean restream, boolean rebuild) {
67-
if (!preloadFiles.isEmpty()) {
68-
HipoReader r = new HipoReader();
69-
r.open(preloadFiles.get(0));
70-
schemaFactory = r.getSchemaFactory();
71-
r.close();
72-
runConfig = new Bank(schemaFactory.getSchema("RUN::config"));
73-
recEvent = new Bank(schemaFactory.getSchema("REC::Event"));
74-
conman = new ConstantsManager();
75-
conman.init(CCDB_TABLES);
76-
helicitySequence = Util.getHelicity(preloadFiles, schemaFactory, restream, conman);
77-
if (rebuild) chargeSequence = DaqScalersSequence.rebuildSequence(1, conman, preloadFiles);
78-
else chargeSequence = DaqScalersSequence.readSequence(preloadFiles);
79-
eventUnix = getEventUnixMap(schemaFactory, preloadFiles);
80-
}
47+
HipoReader r = new HipoReader();
48+
r.open(files.get(0));
49+
schemaFactory = r.getSchemaFactory();
50+
r.close();
51+
runConfig = new Bank(schemaFactory.getSchema("RUN::config"));
52+
recEvent = new Bank(schemaFactory.getSchema("REC::Event"));
53+
conman = new ConstantsManager();
54+
conman.init(CCDB_TABLES);
55+
helicitySequence = Util.getHelicity(files, schemaFactory, restream, conman);
56+
if (rebuild) chargeSequence = DaqScalersSequence.rebuildSequence(1, conman, files);
57+
else chargeSequence = DaqScalersSequence.readSequence(files);
58+
eventUnix = getEventUnixMap(schemaFactory, files);
8159
}
8260

83-
/**
84-
* Get a list of files to preload, from one directory and a glob.
85-
* @param dir
86-
* @param glob
87-
* @return list of preload files
88-
*/
89-
private static List<String> findPreloadFiles(String dir, String glob) {
90-
List<String> ret = new ArrayList<>();
91-
if (dir != null) {
92-
PathMatcher matcher = FileSystems.getDefault().getPathMatcher("glob:"+dir+"/"+glob);
93-
for (File f : (new File(dir)).listFiles()) {
94-
if (matcher.matches(f.toPath()))
95-
ret.add(f.getPath());
96-
}
97-
}
98-
return ret;
61+
public Processor(List<String> files, SchemaFactory schema, HelicitySequenceDelayed h, DaqScalersSequence s) {
62+
schemaFactory = schema;
63+
helicitySequence = h;
64+
chargeSequence = s;
65+
runConfig = new Bank(schemaFactory.getSchema("RUN::config"));
66+
recEvent = new Bank(schemaFactory.getSchema("REC::Event"));
67+
conman = new ConstantsManager();
68+
conman.init(CCDB_TABLES);
69+
eventUnix = getEventUnixMap(schemaFactory, files);
9970
}
10071

10172
/**

0 commit comments

Comments
 (0)