From 1e229e280b36b4fd1f1c9f82e2fe4e12b4c387ab Mon Sep 17 00:00:00 2001 From: Simeon David Schaub Date: Thu, 4 Jun 2026 16:47:03 +0200 Subject: [PATCH] don't depwarn while holding the typeinf lock This causes a context switch, which I believe is illegal while holding the typeinf lock. This caused hangs in the CoolPDLP.jl test suite on Julia 1.10 --- src/driver.jl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/driver.jl b/src/driver.jl index 1d68af36..5ceb74ce 100644 --- a/src/driver.jl +++ b/src/driver.jl @@ -325,14 +325,14 @@ const __llvm_initialized = Ref(false) # target-specific libraries @tracepoint "target libraries" begin if has_legacy_link_libraries(job) - Base.depwarn( - "3-arg `link_libraries!(job, mod, undefined_fns)` is deprecated; " * - "migrate your override to the 2-arg form `link_libraries!(job, mod)`. " * - "Instead of inspecting `undefined_fns` to decide what to link, " * - "parse the library lazily with `parse(LLVM.Module, bytes; lazy=true)` " * - "and link it with `LLVM.link!(mod, lib; only_needed=true)` — " * - "the linker will then materialize only the referenced symbols.", - :link_libraries!) + #Base.depwarn( + # "3-arg `link_libraries!(job, mod, undefined_fns)` is deprecated; " * + # "migrate your override to the 2-arg form `link_libraries!(job, mod)`. " * + # "Instead of inspecting `undefined_fns` to decide what to link, " * + # "parse the library lazily with `parse(LLVM.Module, bytes; lazy=true)` " * + # "and link it with `LLVM.link!(mod, lib; only_needed=true)` — " * + # "the linker will then materialize only the referenced symbols.", + # :link_libraries!) undefined_fns = [LLVM.name(f) for f in functions(ir) if isdeclaration(f) && !LLVM.isintrinsic(f)] link_libraries!(job, ir, undefined_fns)