Without ForceStockRadiatorLogic, foldable radiators have no heat flux

[dvangennip]

I noticed a recent change in the performance of foldable radiator panels (stock and modded). I have the latest version of SystemHeat installed (0.9.1) + the converter and harvester patches, AND I set the ForceStockRadiatorLogic to false to skip the stock behaviour and hopefully gain some performance benefit. However, while static panels can be turned on and off without issue, foldable panels are stuck with 0 heat flux in their extended state. Which is to say, foldable radiators don't work.

So I did some testing on a bare bones install using stock parts:

RUN 1

Installed mods:

• KSPCommunityFixes (not sure if it's relevant, but it's there)
• Heat Control (not used but kept to mimic initial finding)
• Near Future Electrical + soft dependencies (CRP, CTT) (I wanted to generate lots of heat quickly)
• SystemHeat 0.9.1 + all converter, drill, engine patches
• ForceStockRadiatorLogic manually set to false
• RESULT: Static radiator works. Foldable radiator does not work, has no heat flux

RUN 2

• KSPCommunityFixes
• Only base SystemHeat (no extra patches)
• ISRU not converted to SystemHeat
• ForceStockRadiatorLogic is still set to false (which ought to be ignored as converters are not patched)
• RESULT: Static radiator works. Foldable radiator works too.

RUN 3

- KSPCommunityFixes - SystemHeat + converter and drill patches - ForceStockRadiatorLogic set to `false` - **RESULT: Static radiator works. Foldable radiator does not work, has no heat flux**

RUN 4

• As RUN 3, with ForceStockRadiatorLogic set to true
• RESULT: Static radiator works. Foldable radiator works too.

So it appears the ForceStockRadiatorLogic setting, when set to false, causes SystemHeat to miss the radiator extension or prevents it from updating heat flux, which renders foldable radiators ineffective and vessels reliant on them very, very warm.

I haven't looked at the code, but hopefully the above report gives something to go on.

tl;dr;

ForceStockRadiatorLogic set to false causes foldable radiators to not work, setting best left to true in the interim

[dvangennip]

Just continuing the troubleshooting, I noticed that with ForceStockRadiatorLogic set to false (and thus getting the non-functional extended radiators), those radiators do appear to yield correct results in the editor.

Screenshot in SPH showing negative heat flux rate as intended

A quick look at ModuleSystemHeatRadiator.cs:

// line 234 in FixedUpdate() for LoadedSceneIsFlight (just after stock logic fixed update is called conditionally)
if (base.IsCooling)
  ...stuff gets done

// line 281, same method but for editor
if (base.IsCooling || ((base._depRad != null) && (base._depRad.deployState == ModuleDeployablePart.DeployState.EXTENDED))
   ...stuff gets done

Could the missing deployState check in the editor-related block be the solution for in-flight behaviour? It seems running the stock logic might set IsCooling to true based on a radiator's extended state, so skipping it leaves the code in limbo. I have not tested this though.