From 25b573aa89a147761c6d89fe98aa98bac3ff2b02 Mon Sep 17 00:00:00 2001 From: Krakenied Date: Wed, 15 Apr 2026 22:38:34 +0200 Subject: [PATCH] Fix some BigDecimal comparisons Related to https://github.com/LMBishop/Quests/pull/854 Suggested-by: Cyanoure --- .../tasktype/type/dependent/EssentialsBalanceTaskType.java | 4 ++-- .../tasktype/type/dependent/SuperiorSkyblockLevelType.java | 2 +- .../tasktype/type/dependent/SuperiorSkyblockWorthType.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java index 150bf16d8..0db546182 100644 --- a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java +++ b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/EssentialsBalanceTaskType.java @@ -61,7 +61,7 @@ public void onStart(final @NotNull Quest quest, final @NotNull Task task, final int earningsNeeded = (int) task.getConfigValue("amount"); BigDecimal amount = BigDecimal.valueOf(earningsNeeded); - if (balance.compareTo(amount) > 0) { + if (balance.compareTo(amount) >= 0) { super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId()); taskProgress.setCompleted(true); } @@ -92,7 +92,7 @@ public void onUserBalanceUpdate(UserBalanceUpdateEvent event) { int earningsNeeded = (int) task.getConfigValue("amount"); BigDecimal amount = BigDecimal.valueOf(earningsNeeded); - if (balance.compareTo(amount) > 0) { + if (balance.compareTo(amount) >= 0) { super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId()); taskProgress.setCompleted(true); } diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java index 880632af2..d11712252 100644 --- a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java +++ b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockLevelType.java @@ -55,7 +55,7 @@ public void onIslandLevel(IslandWorthUpdateEvent event) { taskProgress.setProgress(event.getNewLevel().doubleValue()); super.debug("Updating task progress (now " + event.getNewLevel().doubleValue() + ")", quest.getId(), task.getId(), player.getUniqueId()); - if (event.getNewLevel().compareTo(bd) > 0) { + if (event.getNewLevel().compareTo(bd) >= 0) { super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId()); taskProgress.setCompleted(true); } diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java index da6a42744..424468664 100644 --- a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java +++ b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/dependent/SuperiorSkyblockWorthType.java @@ -55,7 +55,7 @@ public void onIslandLevel(IslandWorthUpdateEvent event) { taskProgress.setProgress(event.getNewLevel().doubleValue()); super.debug("Updating task progress (now " + event.getNewLevel().doubleValue() + ")", quest.getId(), task.getId(), player.getUniqueId()); - if (event.getNewLevel().compareTo(bd) > 0) { + if (event.getNewLevel().compareTo(bd) >= 0) { super.debug("Marking task as complete", quest.getId(), task.getId(), player.getUniqueId()); taskProgress.setCompleted(true); }