Fix LDK reader crash under ES2023 target of @labkey/api (#303)

labkey-bpatel · web-flow · commit 6404d0f63e18 · 2026-07-13T17:14:58.000-06:00
* drop the redundant `new` from the call to `LABKEY.FieldKey.fromParts(field.fieldKey)`
diff --git a/LDK/resources/web/LDK/data/LabKeyStore.js b/LDK/resources/web/LDK/data/LabKeyStore.js
@@ -53,7 +53,7 @@ Ext4.define('LDK.data.proxy.ExtendedJsonReader', {
         if (data.metaData){
             Ext4.each(data.metaData.fields, function(field){
                 if (!field.name){
-                    var fk = new LABKEY.FieldKey.fromParts(field.fieldKey);
+                    var fk = LABKEY.FieldKey.fromParts(field.fieldKey);
                     field.name = fk.toString();
                 }
             }, this);

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ Ext4.define('LDK.data.proxy.ExtendedJsonReader', {`
`53`	`53`	`if (data.metaData){`
`54`	`54`	`Ext4.each(data.metaData.fields, function(field){`
`55`	`55`	`if (!field.name){`
`56`		`- var fk = new LABKEY.FieldKey.fromParts(field.fieldKey);`
	`56`	`+ var fk = LABKEY.FieldKey.fromParts(field.fieldKey);`
`57`	`57`	`field.name = fk.toString();`
`58`	`58`	`}`
`59`	`59`	`}, this);`