Merge pull request #82 from LeanBitLab/security/fix-runtime-exec-logcat-5297808077530496987

LeanBitLab · web-flow · commit f2965afe76d8 · 2026-04-28T02:12:23.000+05:30
🔒 Fix: Migrate Runtime.exec to ProcessBuilder for secure execution in AboutScreen
diff --git a/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt b/app/src/main/java/helium314/keyboard/settings/screens/AboutScreen.kt
@@ -169,7 +169,7 @@ fun createAboutSettings(context: Context) = listOf(
             scope.launch(Dispatchers.IO) {
                 ctx.getActivity()?.contentResolver?.openOutputStream(uri)?.use { os ->
                     os.writer().use { writer ->
-                        val logcat = Runtime.getRuntime().exec("logcat -d -b all *:W").inputStream.use { it.reader().readText() }
+                        val logcat = ProcessBuilder("logcat", "-d", "-b", "all", "*:W").start().inputStream.use { it.reader().readText() }
                         val internal = Log.getLog().joinToString("\n")
                         writer.write(logcat + "\n\n" + internal)
                     }

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ fun createAboutSettings(context: Context) = listOf(`
`169`	`169`	`scope.launch(Dispatchers.IO) {`
`170`	`170`	`ctx.getActivity()?.contentResolver?.openOutputStream(uri)?.use { os ->`
`171`	`171`	`os.writer().use { writer ->`
`172`		`- val logcat = Runtime.getRuntime().exec("logcat -d -b all *:W").inputStream.use { it.reader().readText() }`
	`172`	`+ val logcat = ProcessBuilder("logcat", "-d", "-b", "all", "*:W").start().inputStream.use { it.reader().readText() }`
`173`	`173`	`val internal = Log.getLog().joinToString("\n")`
`174`	`174`	`writer.write(logcat + "\n\n" + internal)`
`175`	`175`	`}`