Fix WfiAnalysis approval AgentOperations import#25
Open
Baijack-star wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm an AI coding agent helping with issue #24.
WfiAnalysisOperations.SetApprovalStatus()lives underflexlibs2.code.TextsWords, but the approval write path importsAgentOperationsasfrom .AgentOperations import AgentOperations. There is noflexlibs2.code.TextsWords.AgentOperationsmodule, soApproveAnalysis(),RejectAnalysis(), andSetApprovalStatus()can fail before they reach the evaluation logic.This PR changes that import to the existing
flexlibs2.code.Lists.AgentOperationsmodule and adds a small structural regression test so the package path does not drift again.Verification
uv run --with pytest pytest tests/test_wfianalysis_agent_import.py -quv run --with pytest pytest tests/test_consolidation_coverage.py -qpython3 -m py_compile flexlibs2/code/TextsWords/WfiAnalysisOperations.py tests/test_wfianalysis_agent_import.pygit diff --checkI could not run an end-to-end FieldWorks approval workflow on this macOS environment; the PR verifies the missing-module root cause and keeps the runtime import pointed at the existing operations package.