Fixed: can't compare offset-naive and offset-aware datetimes (date_start, date_end comparison)

Author: TheoSabattie

app/crud.py

@@ -288,20 +288,20 @@ def update_election(
         raise errors.ForbiddenError("You are not allowed to manage the election")
 
     if election_ref != election.ref:
-        raise errors.UnauthorizedError("Wrong election ref")
+        raise errors.ForbiddenError("Wrong election ref")
 
     db_election = get_election(db, election_ref)
 
     if db_election is None:
         raise errors.NotFoundError("elections")
 
     if election.date_start is not None and election.date_end is None and db_election.date_end is not None:
-        if election.date_start > db_election.date_end:
+        if schemas.parse_date(election.date_start) > schemas.parse_date(db_election.date_end):
             raise errors.ForbiddenError(
                 "The start date must be before the end date of the election"
             )
     elif election.date_end is not None and election.date_start is None:
-        if election.date_end < db_election.date_start:
+        if schemas.parse_date(election.date_end) < schemas.parse_date(db_election.date_start):
             raise errors.ForbiddenError(
                 "The end date must be after the start date of the election"
             )

app/schemas.py

@@ -83,7 +83,7 @@ def _in_a_long_time() -> datetime:
 def _utc_now() -> datetime:
     return datetime.now(timezone.utc)
 
-def _parse_date(value:datetime | int | str | None):
+def parse_date(value:datetime | int | str | None):
     if value is None:
         return None
 
@@ -124,15 +124,15 @@ class ElectionBase(BaseModel):
 
     @model_validator(mode="after")
     def check_dates_order(self) -> Self:
-        if self.date_start and self.date_end and _parse_date(self.date_start) > _parse_date(self.date_end):
+        if self.date_start and self.date_end and parse_date(self.date_start) > parse_date(self.date_end):
             raise ArgumentsSchemaError("date_start must be before or equal to date_end")
 
         return self
 
     @field_validator("date_end", "date_start", mode="before")
     @classmethod
     def parse_date(cls, value):
-        return _parse_date(value)
+        return parse_date(value)
 
 class ElectionGet(ElectionBase):
     force_close: bool = False
@@ -239,15 +239,15 @@ class ElectionUpdate(BaseModel):
 
     @model_validator(mode="after")
     def check_dates_order(self) -> Self:
-        if self.date_start and self.date_end and _parse_date(self.date_start) > _parse_date(self.date_end):
+        if self.date_start and self.date_end and parse_date(self.date_start) > parse_date(self.date_end):
             raise ArgumentsSchemaError(f"date_start must be before or equal to date_end")
 
         return self
 
     @field_validator("date_end", "date_start", mode="before")
     @classmethod
     def parse_date(cls, value):
-        return _parse_date(value)
+        return parse_date(value)
 
     @field_validator("grades")
     @classmethod