Feat/perps add position#6400
Open
SeniorZhai wants to merge 41 commits into
Open
Conversation
- Replace PerpsPositionShareActivity with PerpsPositionShareBottomFragment - Add share poster layouts (classic/minimal profit/loss) - Add share card background drawables
- Add PerpsAddBottomSheetDialogFragment (add position UI) - Add OpenOrderRequest and update RouteService for add position API - Add PerpsDatabase migration v3→v4, PerpsOrderDao, PerpsOrderItem - Remove PerpsPositionHistory and PerpsPositionHistoryDao - Update PerpetualViewModel with add position logic - Update PerpsMarketDetailPage with add position entry - Update ClosedPositionItem for PerpsOrderItem model - Update PositionDetailFragment/Page for share bottom sheet - Update DI module (PerpsModule)
SeniorZhai
force-pushed
the
feat/perps-add-position
branch
from
6d38899 to
37dbc01
Compare
…list - Remove WHERE order_type='close' filter from PerpsOrderDao queries - Add OpenedOrderItem composable for open/increase_position order display - Update AllPositionsPage to differentiate close vs opened orders by orderType - Update PerpsMarketDetailPage ClosedPositionsSection for opened orders - Add perps_opened/perps_added string resources (en + zh)
…ding, add guide dialog diagnostics
- Filter out orders with status='opening' from activity queries - Unify activity list titles as 'Opened/Closed Long/Short' - Center PnL vertically in ClosedPositionItem; drop time from OpenedOrderItem - Add OpenedOrderDetailPage with View Market and Share actions - Route opened orders to new detail page in PositionDetailFragment - Use accent color and 'Close Position' label for market detail close button
SeniorZhai
force-pushed
the
feat/perps-add-position
branch
from
8bfd503 to
db21032
Compare
The confirm sheet never reset errorInfo, so a successful retry still showed the stale error subtitle instead of the success message. Clear it when sending starts. In the add-position sheet the Compose context is a Hilt FragmentContextWrapper, so `context as? FragmentActivity` was always null and the guide dialog never opened. Use findFragmentActivityOrNull to unwrap it, and apply the same fix to the add-fee action.
- Replace 'opening' with 'processing' status to match backend semantics - Exclude 'processing' orders from activity and history SQL queries - Update trading strings and Chinese translations for better clarity - Dim leverage colors in PositionDetailPage based on order status - Handle and display failure states for open, close, and increase orders
SeniorZhai
force-pushed
the
feat/perps-add-position
branch
from
d162fa4 to
c990b0d
Compare
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: SeniorZhai <5416585+SeniorZhai@users.noreply.github.com>
Contributor
Resolved and pushed. I merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
generateQRCode's qrSize only derives the integer module scale factor, so without outputSize the produced bitmap size depended on QR content length and integer truncation. Pass outputSize to lock the bitmap to the requested dimension, and resize the share QR to 72dp (72dp container, 16dp logo) to match the perps share card. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The market and perps share card footers used fixed heights, leaving inconsistent spacing around the QR code. Switch both footers to wrap_content so they grow with the QR container and keep a uniform 12dp top/bottom padding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
A merge from master reintroduced the position history share path into the share and detail fragments, but PerpsPositionHistory and its DAO were deprecated and deleted on this branch, so the branch no longer compiled. Restore both fragments to their pre-merge state, dropping the PerpsPositionHistoryItem references. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.