Skip to content

Commit 8121aae

Browse files
committed
fix: use shell variables instead of NSIS constants in VIProductVersion
- Change VIProductVersion from ${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}.0 - To VIProductVersion ...0 - Fix NSIS version format validation error
1 parent bdd9374 commit 8121aae

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ jobs:
145145
146146
# Extraire les composants de version (ex: 0.2.1 -> 0, 2, 1)
147147
IFS='.' read -ra VERSION_PARTS <<< "$VERSION"
148+
PATCH=${VERSION_PARTS[3]:-0}
148149
MAJOR=${VERSION_PARTS[0]:-0}
149150
MINOR=${VERSION_PARTS[1]:-0}
150151
BUILD=${VERSION_PARTS[2]:-0}
@@ -175,7 +176,7 @@ jobs:
175176
RequestExecutionLevel user
176177
177178
; Métadonnées de l'installateur
178-
VIProductVersion "${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}.0"
179+
VIProductVersion "${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}.${PATCH}"
179180
VIAddVersionKey "ProductName" "${APPNAME}"
180181
VIAddVersionKey "CompanyName" "${COMPANYNAME}"
181182
VIAddVersionKey "FileDescription" "${DESCRIPTION}"
@@ -285,6 +286,7 @@ jobs:
285286
286287
# Extraire les composants de version
287288
IFS='.' read -ra VERSION_PARTS <<< "$VERSION"
289+
PATCH=${VERSION_PARTS[3]:-0}
288290
MAJOR=${VERSION_PARTS[0]:-0}
289291
MINOR=${VERSION_PARTS[1]:-0}
290292
BUILD=${VERSION_PARTS[2]:-0}
@@ -318,7 +320,7 @@ jobs:
318320
RequestExecutionLevel admin
319321
320322
; Métadonnées de l'installateur
321-
VIProductVersion "${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}.0"
323+
VIProductVersion "${VERSIONMAJOR}.${VERSIONMINOR}.${VERSIONBUILD}.${PATCH}"
322324
VIAddVersionKey "ProductName" "${APPNAME}"
323325
VIAddVersionKey "CompanyName" "${COMPANYNAME}"
324326
VIAddVersionKey "FileDescription" "${DESCRIPTION}"

0 commit comments

Comments
 (0)