From 112f06f2108bf430fc22e90cd3accb69c3c4ee28 Mon Sep 17 00:00:00 2001 From: Aiden Park <275402320+vip892766gma@users.noreply.github.com> Date: Thu, 14 May 2026 04:25:06 +0000 Subject: [PATCH 1/2] docs: fix duplicated words in host_stub_visibility and permutation_iterator comments --- docs/cccl/development/visibility/host_stub_visibility.rst | 2 +- libcudacxx/include/cuda/__iterator/permutation_iterator.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/cccl/development/visibility/host_stub_visibility.rst b/docs/cccl/development/visibility/host_stub_visibility.rst index 1e870c1900a..c68f793e30b 100644 --- a/docs/cccl/development/visibility/host_stub_visibility.rst +++ b/docs/cccl/development/visibility/host_stub_visibility.rst @@ -69,7 +69,7 @@ However, imagine that there are two shared libraries: ``lib_a`` and ``lib_b`` bo add_library(lib_b SHARED tu_b.cu) target_link_libraries(host_stub_visibility PRIVATE lib_a lib_b) -Each library will have it's own fatbinary: ``d_kernel_a`` and ``d_kernel_b``, but the the compiler +Each library will have it's own fatbinary: ``d_kernel_a`` and ``d_kernel_b``, but the compiler generated host stub function ``h_kernel`` has weak external linkage, so after dynamic linkage, we'll end up having only one of them. diff --git a/libcudacxx/include/cuda/__iterator/permutation_iterator.h b/libcudacxx/include/cuda/__iterator/permutation_iterator.h index 6b61bcd644f..7c7491d3e8c 100644 --- a/libcudacxx/include/cuda/__iterator/permutation_iterator.h +++ b/libcudacxx/include/cuda/__iterator/permutation_iterator.h @@ -164,7 +164,7 @@ class permutation_iterator {} //! @brief Constructs an @c permutation_iterator from an iterator and an optional index - //! @param __iter The iterator to to index from + //! @param __iter The iterator to index from //! @param __index The iterator with the permutations _CCCL_EXEC_CHECK_DISABLE _CCCL_API constexpr permutation_iterator(_Iter __iter, _Index __index) noexcept( From 2f9566667e3b616772916880c2d3a88306512d18 Mon Sep 17 00:00:00 2001 From: Jacob Faibussowitsch Date: Thu, 14 May 2026 10:36:50 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- docs/cccl/development/visibility/host_stub_visibility.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cccl/development/visibility/host_stub_visibility.rst b/docs/cccl/development/visibility/host_stub_visibility.rst index c68f793e30b..b98ad872b07 100644 --- a/docs/cccl/development/visibility/host_stub_visibility.rst +++ b/docs/cccl/development/visibility/host_stub_visibility.rst @@ -69,7 +69,7 @@ However, imagine that there are two shared libraries: ``lib_a`` and ``lib_b`` bo add_library(lib_b SHARED tu_b.cu) target_link_libraries(host_stub_visibility PRIVATE lib_a lib_b) -Each library will have it's own fatbinary: ``d_kernel_a`` and ``d_kernel_b``, but the compiler +Each library will have its own fatbinary: ``d_kernel_a`` and ``d_kernel_b``, but the compiler generated host stub function ``h_kernel`` has weak external linkage, so after dynamic linkage, we'll end up having only one of them.