diff --git a/routes/api.php b/routes/api.php index 02207409..64d0af2d 100644 --- a/routes/api.php +++ b/routes/api.php @@ -2,7 +2,6 @@ use App\Http\Middleware\VerifyCsrfToken; use Illuminate\Support\Facades\Route; -use Native\Desktop\Http\Controllers\CreateSecurityCookieController; use Native\Desktop\Http\Controllers\DispatchEventFromAppController; use Native\Desktop\Http\Controllers\NativeAppBootedController; use Native\Desktop\Http\Middleware\OptionalNightwatchNever; @@ -12,5 +11,3 @@ Route::post('_native/api/booted', NativeAppBootedController::class); Route::post('_native/api/events', DispatchEventFromAppController::class); })->withoutMiddleware(VerifyCsrfToken::class); - -Route::get('_native/api/cookie', CreateSecurityCookieController::class)->middleware(OptionalNightwatchNever::class); diff --git a/src/Http/Controllers/CreateSecurityCookieController.php b/src/Http/Controllers/CreateSecurityCookieController.php deleted file mode 100644 index 6736ca2e..00000000 --- a/src/Http/Controllers/CreateSecurityCookieController.php +++ /dev/null @@ -1,20 +0,0 @@ -input('secret') !== config('native-php.secret'), 403); - - return redirect('/')->cookie(cookie( - name: '_php_native', - value: config('native-php.secret'), - domain: 'localhost', - httpOnly: true, - )); - } -} diff --git a/src/Http/Middleware/PreventRegularBrowserAccess.php b/src/Http/Middleware/PreventRegularBrowserAccess.php index 2e482089..19e35de1 100644 --- a/src/Http/Middleware/PreventRegularBrowserAccess.php +++ b/src/Http/Middleware/PreventRegularBrowserAccess.php @@ -13,11 +13,6 @@ public function handle(Request $request, Closure $next) return $next($request); } - // Explicitly skip for the cookie-setting route - if ($request->path() === '_native/api/cookie') { - return $next($request); - } - $cookie = $request->cookie('_php_native'); $header = $request->header('X-NativePHP-Secret'); diff --git a/tests/Http/Controller/CreateSecurityCookieControllerTest.php b/tests/Http/Controller/CreateSecurityCookieControllerTest.php deleted file mode 100644 index 33b17f14..00000000 --- a/tests/Http/Controller/CreateSecurityCookieControllerTest.php +++ /dev/null @@ -1,18 +0,0 @@ -get('_native/api/cookie')->assertRedirect('/'); - $cookie = $response->headers->getCookies()[0]; - - $this->assertEquals('_php_native', $cookie->getName()); - $this->assertEquals('localhost', $cookie->getDomain()); - $this->assertTrue($cookie->isHttpOnly()); -}); - -it('check if secret is not equal of config secret key abort 403 page', function () { - config()->set('native-php.secret', 'milwad'); - - $response = $this->get('_native/api/cookie')->assertStatus(403); - - $this->assertEquals([], $response->headers->getCookies()); -});