Skip to content

Commit a6b07c1

Browse files
committed
chore(options): declare solid, drop stale flags and era artifacts
`--solid` is a first-class template flavor alongside --vue/--react/--svelte and is read in create-project.ts, but was never declared in the options dictionary. Only `vision-solid` was. The `whatever` dashedOption on the prepare command was placeholder junk. `ui`, `recursive`, `reporter` and `require` in optionsWhiteList are mocha CLI arguments from when the suite ran on mocha; nothing in the CLI reads them. `timeout` stays: unlike the rest it names a real, documented option that lib code reads. `--static-bindings` in the build android synopsis has no counterpart in lib/ and never did.
1 parent 93641e5 commit a6b07c1

3 files changed

Lines changed: 3 additions & 15 deletions

File tree

docs/man_pages/project/testing/build-android.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Builds the project for Android and produces an APK that you can manually deploy
1313

1414
Usage | Synopsis
1515
---|---
16-
General | `$ ns build android [--compileSdk <API Level>] [--key-store-path <File Path> --key-store-password <Password> --key-store-alias <Name> --key-store-alias-password <Password>] [--release] [--static-bindings] [--copy-to <File Path>] [--env.*]] [--aab]`
16+
General | `$ ns build android [--compileSdk <API Level>] [--key-store-path <File Path> --key-store-password <Password> --key-store-alias <Name> --key-store-alias-password <Password>] [--release] [--copy-to <File Path>] [--env.*]] [--aab]`
1717

1818
### Options
1919

lib/commands/prepare.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ export class PrepareCommand
2727
default: false,
2828
hasSensitiveValue: false,
2929
},
30-
whatever: {
31-
type: OptionType.Boolean,
32-
default: false,
33-
hasSensitiveValue: false,
34-
},
3530
};
3631

3732
constructor(

lib/options.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,7 @@ export class Options {
1515
private static DASHED_OPTION_REGEX = /(.+?)([A-Z])(.*)/;
1616
private static NONDASHED_OPTION_REGEX = /(.+?)[-]([a-zA-Z])(.*)/;
1717

18-
private optionsWhiteList = [
19-
"ui",
20-
"recursive",
21-
"reporter",
22-
"require",
23-
"timeout",
24-
"_",
25-
"$0",
26-
]; // These options shouldn't be validated
18+
private optionsWhiteList = ["timeout", "_", "$0"]; // These options shouldn't be validated
2719
private globalOptions: IDictionary<IDashedOption> = {
2820
log: { type: OptionType.String, hasSensitiveValue: false },
2921
verbose: { type: OptionType.Boolean, hasSensitiveValue: false },
@@ -133,6 +125,7 @@ export class Options {
133125
vue: { type: OptionType.Boolean, hasSensitiveValue: false },
134126
vuejs: { type: OptionType.Boolean, hasSensitiveValue: false },
135127
svelte: { type: OptionType.Boolean, hasSensitiveValue: false },
128+
solid: { type: OptionType.Boolean, hasSensitiveValue: false },
136129
vision: { type: OptionType.Boolean, hasSensitiveValue: false },
137130
"vision-ng": { type: OptionType.Boolean, hasSensitiveValue: false },
138131
"vision-react": { type: OptionType.Boolean, hasSensitiveValue: false },

0 commit comments

Comments
 (0)