chore(options): drop the shadowed array declaration of config

commonOptions declared config as Array, but the dictionary is built with
globalOptions extending over commonOptions, so the String declaration
(alias -c) always won and the Array entry was unreachable. The test
exercising the array-length check now declares its own array option
instead of leaning on the shadowed entry.

Author: edusperoni

lib/options.ts

@@ -172,8 +172,6 @@ export class Options {
 			},
 			json: { type: OptionType.Boolean, hasSensitiveValue: false },
 			avd: { type: OptionType.String, hasSensitiveValue: true },
-			// check not used
-			config: { type: OptionType.Array, hasSensitiveValue: false },
 			insecure: {
 				type: OptionType.Boolean,
 				alias: "k",

test/options.ts

@@ -243,9 +243,11 @@ describe("options", () => {
 		});
 
 		it("breaks execution when valid array option has value with length 0", () => {
-			process.argv.push("--config");
+			process.argv.push("--test1");
 			const options = createOptions(testInjector);
-			options.validateOptions();
+			options.validateOptions({
+				test1: { type: OptionType.Array, hasSensitiveValue: false },
+			});
 			process.argv.pop();
 			assert.isTrue(isExecutionStopped);
 		});