kalama: many modules not built when using the default build command.

[shamefulCake1]

ace 2 pro

The kernel_manifest README.md tells me to build the kernel with ./kernel_platform/oplus/build/oplus_build_kernel.sh kalama gki, but when this command finishes, there is no file called out/dist/wcd938x_slave_dlkm.so, which is included in the OTA vendor_dlkm.img/lib/modules/wcd937x_slave_dlkm.ko

The file vendor/qcom/opensource/audio-kernel/Android.mk seems to be only building this file for a board called "bengal":

ifneq ($(call is-board-platform-in-list, bengal),true)

Is this a bug, or should the kernel for kalama be built differently?

Grepping the device tree for wcd938 shows that this chip is present in the phone.

camera.ko also does not seem to get built

[nullptr-t-oss]

ace 2 pro

The kernel_manifest README.md tells me to build the kernel with ./kernel_platform/oplus/build/oplus_build_kernel.sh kalama gki, but when this command finishes, there is no file called out/dist/wcd938x_slave_dlkm.so, which is included in the OTA vendor_dlkm.img/lib/modules/wcd937x_slave_dlkm.ko

The file vendor/qcom/opensource/audio-kernel/Android.mk seems to be only building this file for a board called "bengal":

ifneq ($(call is-board-platform-in-list, bengal),true)

Is this a bug, or should the kernel for kalama be built differently?

Grepping the device tree for wcd938 shows that this chip is present in the phone.

camera.ko also does not seem to get built

Hi a lot of modules are not automatically built by oplus scripts, either you need to export paths or build manually. In both cases you need to fix the sources.

To fix sources inside the parent of kernel_platform folder, do :

git remote add nullptr https://github.com/nullptr-t-oss/android_kernel_modules_and_devicetree_oneplus_sm8550.git
git fetch nullptr
git cherry-pick 0a82a8d27a4126ffe233186c18bb909e2cf44600^..c6b1b8acebf17def5c982b7b43e86746c0029be7

Note : if you face conflict at commit 5b8107c you'll probably see this inside vendor/qcom/opensource/graphics-kernel/Kbuild :

<<<<<<< HEAD
=======

CONFIG_OPLUS_SYNC_FENCE = m
ccflags-y += -I$(KERNEL_SRC)
obj-$(CONFIG_OPLUS_SYNC_FENCE) += oplus_sync_fence.o
oplus_sync_fence-y = oplus_sync_fence/oplus_sync_file.o
>>>>>>> 5b8107c5 (KBUILD: use already defined defconfigs for compilation)

If you see this just delete this whole part and run :

git add .
git cherry-pick --continue

After that if you decide to build manually follow the build process in this repo : EmberHeart_OnepPlus11

[nullptr-t-oss]

Note : still you won't be able to build few modules (sources not released) Check Issue#19

[shamefulCake1]

Note : still you won't be able to build few modules (sources not released) Check Issue#19

Hm...

I'm not using oneplus 11, I'm using ace 2 pro, which is more or less like 12r.

Aosp works on the stock lineage kernel, but WiFi is broken due to hanging firmware. I don't know why, something related to qcacld2, which, I think, is the wifi driver.

[nullptr-t-oss]

Note : still you won't be able to build few modules (sources not released) Check Issue#19

Hm...

I'm not using oneplus 11, I'm using ace 2 pro, which is more or less like 12r.

Aosp works on the stock lineage kernel, but WiFi is broken due to hanging firmware. I don't know why, something related to qcacld2, which, I think, is the wifi driver.

Doesn't matter, I cherry picked commits to ace3 & it worked fine

Note : qcacld2 is replaced by qcacld3 (since OnePlus 3).

[shamefulCake1]

git remote add nullptr https://github.com/nullptr-t-oss/android_kernel_modules_and_devicetree_oneplus_sm8550.git

Would you like to make a pull request to this repo, @nullptr-t-oss ?

[nullptr-t-oss]

git remote add nullptr https://github.com/nullptr-t-oss/android_kernel_modules_and_devicetree_oneplus_sm8550.git

Would you like to make a pull request to this repo, @nullptr-t-oss ?

I don't think oneplus will merge it.
Also admin didn't reply to my previous issue.

[shamefulCake1]

@nullptr-t-oss well, then at least people will know about your branch.

Thank you for spending time and effort on making the build work.

(I still have not understood completely how you are building, you do not seem to be using ./kernel_platform/oplus/build/oplus_build_kernel.sh kalama gki.)

[nullptr-t-oss]

@nullptr-t-oss well, then at least people will know about your branch.

Thank you for spending time and effort on making the build work.

(I still have not understood completely how you are building, you do not seem to be using ./kernel_platform/oplus/build/oplus_build_kernel.sh kalama gki.)

Because I am building "manually" using make. Oplus scripts also builds internally using make.

[shamefulCake1]

Also, quoting GPL:

The source code for a work means the preferred form of the work for
making modifications to it.  For an executable work, complete source
code means all the source code for all modules it contains, plus any
associated interface definition files, plus the scripts used to
control compilation and installation of the executable.  However, as a
special exception, the source code distributed need not include
anything that is normally distributed (in either source or binary
form) with the major components (compiler, kernel, and so on) of the
operating system on which the executable runs, unless that component
itself accompanies the executable.

So they actually must provide the build script.

@OnePlusOSSAdmin

[nullptr-t-oss]

Also, quoting GPL:

The source code for a work means the preferred form of the work for
making modifications to it.  For an executable work, complete source
code means all the source code for all modules it contains, plus any
associated interface definition files, plus the scripts used to
control compilation and installation of the executable.  However, as a
special exception, the source code distributed need not include
anything that is normally distributed (in either source or binary
form) with the major components (compiler, kernel, and so on) of the
operating system on which the executable runs, unless that component
itself accompanies the executable.

So they actually must provide the build script.

@OnePlusOSSAdmin

Anyways since you suggested , I'll open pr with the build fixes ,but note these fixes are for oos16 branches only;

If you need to compile them, use :

        cd "$KERNEL_PLATFORM"

        # OPLUS ext modules list
        ext_oplus=($(cat "$KERNEL_PLATFORM/oplus/config/modules.ext.$KERNEL_VER.oplus"))

        # OPLUS ext modules
        for module in "${ext_oplus[@]}"; do
            make -C "$module" M="../$module" -j$(nproc --all) ARCH=arm64 KERNEL_SRC=$KERNEL_PLATFORM/./msm-kernel O=$MSM/out LLVM=1 LLVM_IAS=1 DEPMOD=depmod DTC=dtc CHIPSET_COMPANY=QCOM OPLUS_VND_BUILD_PLATFORM=$SOC
            make -C "$module" M="../$module" -j$(nproc --all) ARCH=arm64 KERNEL_SRC=$KERNEL_PLATFORM/./msm-kernel O=$MSM/out LLVM=1 LLVM_IAS=1 DEPMOD=depmod DTC=dtc CHIPSET_COMPANY=QCOM OPLUS_VND_BUILD_PLATFORM=$SOC INSTALL_MOD_PATH=$INSTALL_MOD_PATH modules_install
        done

        # QCOM ext modules
        ext_qcom+=(
            ../vendor/qcom/opensource/mmrm-driver
            ../vendor/qcom/opensource/mm-drivers/hw_fence
            ../vendor/qcom/opensource/mm-drivers/sync_fence
            ../vendor/qcom/opensource/mm-drivers/msm_ext_display
            ../vendor/qcom/opensource/securemsm-kernel
            ../vendor/qcom/opensource/display-drivers/msm
            ../vendor/qcom/opensource/audio-kernel
            ../vendor/qcom/opensource/camera-kernel
            ../vendor/oplus/kernel/explorer
            ../vendor/qcom/opensource/video-driver
            ../vendor/qcom/opensource/graphics-kernel
            ../vendor/qcom/opensource/dataipa/drivers/platform/msm
            ../vendor/qcom/opensource/datarmnet/core
            ../vendor/qcom/opensource/datarmnet-ext/aps
            ../vendor/qcom/opensource/datarmnet-ext/offload
            ../vendor/qcom/opensource/datarmnet-ext/shs
            ../vendor/qcom/opensource/datarmnet-ext/sch
            ../vendor/qcom/opensource/datarmnet-ext/perf
            ../vendor/qcom/opensource/datarmnet-ext/perf_tether
            ../vendor/qcom/opensource/datarmnet-ext/wlan
            ../vendor/qcom/opensource/eva-kernel
            ../vendor/qcom/opensource/wlan/platform
            ../vendor/qcom/opensource/bt-kernel
            ../vendor/nxp/opensource/driver
            ../vendor/st/opensource/driver
            ../vendor/st/opensource/eSE-driver
            ../vendor/qcom/opensource/wlan/qcacld-3.0
        )

        # add for oplus explorer.ko
        qcom_flags=(
            CHIPSET_COMPANY=QCOM
            OPLUS_VND_BUILD_PLATFORM=$SOC
        )

        cd "$MSM"
        make ARCH=arm64 LLVM=1 O=out oldconfig && make ARCH=arm64 LLVM=1 O=out prepare

        cd "$KERNEL_PLATFORM"

        for module in "${ext_qcom[@]}"; do
            make -C "$module" M="../$module" -j$(nproc --all) ARCH=arm64 KERNEL_SRC=$KERNEL_PLATFORM/./msm-kernel O=$MSM/out LLVM=1 LLVM_IAS=1 DEPMOD=depmod DTC=dtc "${qcom_flags[@]}" modules
            make -C "$module" M="../$module" -j$(nproc --all) ARCH=arm64 KERNEL_SRC=$KERNEL_PLATFORM/./msm-kernel O=$MSM/out LLVM=1 LLVM_IAS=1 DEPMOD=depmod DTC=dtc "${qcom_flags[@]}" INSTALL_MOD_PATH=$INSTALL_MOD_PATH modules_install
        done

Make sure KERNEL_PLATFORM has absolute path of kernel_platform folder and MSM has absolute path of kernel_platform/msm-kernel.

Also $MSM/out directory must be created before compilation for external modules are started.

INSTALL_MOD_PATH : $MSM/out

[shamefulCake1]

@nullptr-t-oss shouldn't make prepare be done before the first set of modules is built?

[nullptr-t-oss]

@nullptr-t-oss shouldn't make prepare be done before the first set of modules is built?

Yes

but you can skip it if you have already compiled in-tree modules just before compiling external modules.

[shamefulCake1]

@nullptr-t-oss could you give me a script which compiles everything ?

[nullptr-t-oss]

@nullptr-t-oss could you give me a script which compiles everything ?

Check this repo

Check

.github/kernel_modules/action.yml

And try to create your own local build scripts or just fork and build on CI.