null ref in TwoStepDeviceBuilder.ElaborateTwoStepDeviceWithToken with some user agent strings from googlebot and bingbot

[jamesmanning]

Exception type: NullReferenceException 
Exception message: Object reference not set to an instance of an object.
   at Oddr.Builders.Devices.TwoStepDeviceBuilder.ElaborateTwoStepDeviceWithToken(UserAgent userAgent, String step1Token, String step2Token)
   at Oddr.Builders.Devices.TwoStepDeviceBuilder.Build(UserAgent userAgent, Int32 confidenceTreshold)
   at Oddr.Identificators.DeviceIdentificator.Get(UserAgent userAgent, Int32 confidenceTreshold)
   at Oddr.ODDRService.GetPropertyValues(IEvidence evdnc, IPropertyRef[] prs)
   at Oddr.ODDRService.GetPropertyValue(IEvidence evdnc, IPropertyRef pr)

User agent strings that appear to trigger it include these (the +'s are there

• DoCoMo/2.0 N905i(c100;TB;W24H16) (compatible; Googlebot-Mobile/2.1; http://www.google.com/bot.html)
• SAMSUNG-SGH-E250/1.0 Profile/MIDP-2.0 Configuration/CLDC-1.1 UP.Browser/6.2.3.3.c.1.101 (GUI) MMP/2.0 (compatible; Googlebot-Mobile/2.1; http://www.google.com/bot.html)
• Mozilla/5.0 (compatible; bingbot/2.0; http://www.bing.com/bingbot.htm)
• Mozilla/5.0 (compatible; Googlebot/2.1; http://www.google.com/bot.html)

[bubbafat]

The problem is that in TwoStepDeviceBuilder.AferOrderingCompleteInit the collection orderedRules is modified during enumeration. It causes an exception to be thrown which results in the devices field to never be set which results in the null ref exception in ElaborateTwoStepDeviceWithToken

[bubbafat]

This fixes it.

    protected override void AfterOrderingCompleteInit(Dictionary<string, Device> devices)
    {
        List<string> keys = new List<string>();
        foreach (string key in orderedRules.Keys)
        {
            keys.Add(key);
        }

        foreach (String step1Token in keys)
        {

            SortElement(step1Token);
        }...