chore: migrate embedded-services pins from v0.2.0 to main#22
Closed
dymk wants to merge 1 commit into
Closed
Conversation
Update all platform Cargo.toml files to reference the main branch of embedded-services instead of v0.2.0. The APIs are identical since PR #852 was merged to both branches, so no code changes are needed. This ensures consistent trait resolution across all platforms and prepares for upcoming features that target the main branch.
dymk
requested review from
Copilot,
kat-perez,
maxperga-msft,
philgweber and
rogurr
There was a problem hiding this comment.
Pull request overview
This PR updates the embedded firmware platforms to consume OpenDevicePartnership/embedded-services from the main branch (instead of v0.2.0), and refreshes each platform’s lockfiles and cargo-vet metadata to match the new resolved dependency graph.
Changes:
- Switched all
embedded-services-sourced dependencies inplatform-commontobranch = "main". - Switched each platform’s
uart-servicedependency tobranch = "main". - Regenerated all platform
Cargo.lockfiles and allsupply-chain/(cargo-vet) files.
Reviewed changes
Copilot reviewed 9 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| platform/platform-common/Cargo.toml | Move embedded-services and related service crates from v0.2.0 to main. |
| platform/platform-common/Cargo.lock | Lockfile refresh after switching to main (includes dependency graph changes). |
| platform/dev-qemu/Cargo.toml | Move uart-service from v0.2.0 to main. |
| platform/dev-qemu/Cargo.lock | Lockfile refresh for dev-qemu after switching to main. |
| platform/dev-qemu/supply-chain/config.toml | cargo-vet config regeneration (exemptions updated). |
| platform/dev-qemu/supply-chain/imports.lock | cargo-vet imports lock regeneration (audits/import sources updated). |
| platform/dev-npcx/Cargo.toml | Move uart-service from v0.2.0 to main. |
| platform/dev-npcx/Cargo.lock | Lockfile refresh for dev-npcx after switching to main. |
| platform/dev-npcx/supply-chain/config.toml | cargo-vet config regeneration (exemptions updated). |
| platform/dev-npcx/supply-chain/imports.lock | cargo-vet imports lock regeneration (audits/import sources updated). |
| platform/dev-mcxa/Cargo.toml | Move uart-service from v0.2.0 to main. |
| platform/dev-mcxa/Cargo.lock | Lockfile refresh for dev-mcxa after switching to main. |
| platform/dev-mcxa/supply-chain/config.toml | cargo-vet config regeneration (exemptions updated). |
| platform/dev-mcxa/supply-chain/imports.lock | cargo-vet imports lock regeneration (audits/import sources updated). |
| platform/dev-imxrt/Cargo.toml | Move uart-service from v0.2.0 to main. |
| platform/dev-imxrt/Cargo.lock | Lockfile refresh for dev-imxrt after switching to main. |
| platform/dev-imxrt/supply-chain/config.toml | cargo-vet config regeneration (exemptions updated). |
| platform/dev-imxrt/supply-chain/imports.lock | cargo-vet imports lock regeneration (audits/import sources updated). |
Comment on lines
+56
to
58
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } |
RobertZ2011
approved these changes
May 22, 2026
| "mimxrt685s", | ||
| ] } | ||
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ |
There was a problem hiding this comment.
nit: Do we want to keep branch = part or just delete it entirely?
Contributor
Author
|
Recreating from fork branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate all platform Cargo.toml files to reference the
mainbranch of embedded-services instead ofv0.2.0. The APIs are identical since embedded-services PR #852 was merged to both branches, so no code changes are needed.This ensures consistent trait resolution across all platforms and prepares for upcoming features that target the
mainbranch.Changes
platform-common/Cargo.toml: 11 branch refs updateddev-imxrt/Cargo.toml: 1 branch ref updateddev-mcxa/Cargo.toml: 1 branch ref updateddev-npcx/Cargo.toml: 1 branch ref updatedCargo.lockfiles regeneratedsupply-chain/(cargo-vet) files regenerated