Update embedded-services dependency to main branch#24
Closed
jerrysxie wants to merge 1 commit into
Closed
Conversation
Switch all embedded-services git dependencies from the v0.2.0 branch to main across all platform Cargo.toml files and update the corresponding lock files. Assisted-by: GitHub Copilot:claude-opus-4.6
jerrysxie
requested review from
Copilot,
dymk,
kat-perez,
maxperga-msft and
rogurr
Copilot stopped reviewing on behalf of
jerrysxie due to an error
May 23, 2026 01:50
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Rust platform crates to pull embedded-services (and related service crates) from the main branch instead of v0.2.0.
Changes:
- Switched multiple git dependencies from
branch = "v0.2.0"tobranch = "main". - Updated the same dependency source across
platform-commonand multiple device/dev crates.
Reviewed changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| platform/platform-common/Cargo.toml | Moves all embedded-services-derived dependencies to track main. |
| platform/dev-qemu/Cargo.toml | Moves uart-service dependency to track main. |
| platform/dev-npcx/Cargo.toml | Moves uart-service dependency to track main. |
| platform/dev-mcxa/Cargo.toml | Moves uart-service dependency to track main. |
| platform/dev-imxrt/Cargo.toml | Moves uart-service dependency to track main. |
Comment on lines
+18
to
+25
| embedded-services = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main" } | ||
| battery-service = { package = "battery-service", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| battery-service-interface = { package = "battery-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| battery-service-interface = { package = "battery-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| battery-service-relay = { package = "battery-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| battery-service-relay = { package = "battery-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ |
Comment on lines
+29
to
+35
| thermal-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| thermal-service-interface = { package = "thermal-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| thermal-service-interface = { package = "thermal-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| thermal-service-relay = { package = "thermal-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| thermal-service-relay = { package = "thermal-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ |
Comment on lines
+39
to
+48
| time-alarm-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| time-alarm-service-interface = { package = "time-alarm-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| time-alarm-service-interface = { package = "time-alarm-service-interface", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| time-alarm-service-relay = { package = "time-alarm-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| time-alarm-service-relay = { package = "time-alarm-service-relay", git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } | ||
| odp-service-common = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0" } | ||
| odp-service-common = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main" } |
Comment on lines
+56
to
58
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ | ||
| "defmt", | ||
| ] } |
| "mimxrt685s", | ||
| ] } | ||
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "v0.2.0", features = [ | ||
| uart-service = { git = "https://github.com/OpenDevicePartnership/embedded-services", branch = "main", features = [ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch all embedded-services git dependencies from the v0.2.0 branch to main across all platform Cargo.toml files and update the corresponding lock files.
Assisted-by: GitHub Copilot:claude-opus-4.6