Update locale attribute names for Diplomat locale-based labels#757
Open
Rub21 wants to merge 14 commits into
Open
Update locale attribute names for Diplomat locale-based labels#757Rub21 wants to merge 14 commits into
Rub21 wants to merge 14 commits into
Conversation
1ec5
reviewed
May 6, 2026
1ec5
approved these changes
May 15, 2026
1ec5
reviewed
May 20, 2026
1ec5
approved these changes
May 22, 2026
| -- Normalize Unicode quotes/primes to ASCII; map NBSP to space. | ||
| s := translate(input, | ||
| E'‘’‛′“”‟″ ', | ||
| '''''''''""""' || ' '); |
Member
There was a problem hiding this comment.
This is my new favorite example of quote escaping. 😊
1ec5
reviewed
May 22, 2026
| NULL, | ||
| NULL | ||
| '(class = ''building:part'') AS is_building_part, EXISTS (SELECT 1 FROM osm_buildings_relation_members obrm WHERE obrm.member = ABS(osm_buildings.osm_id) AND obrm.role = ''outline'') AS hide_3d', | ||
| '{"height": "COALESCE(parse_to_meters(height), parse_to_meters(building_height))", "min_height": "parse_to_meters(min_height)", "roof_height": "parse_to_meters(roof_height)", "building_levels": "clean_numeric(building_levels)", "building_min_level": "clean_numeric(building_min_level)"}'::jsonb, |
Member
There was a problem hiding this comment.
By the way, most OSM tilesets seem to omit building:levels=* and building:min_level=*, instead using these tags as a fallback in case height=* and min_height=* are missing, respectively. They generally assume that a level is 3 meters tall. Some tilesets randomize the heights slightly so that adjacent buildings with the same number of levels look distinct on the map. A stylesheet can’t do that because it evaluates each building individually without context about surrounding buildings.
We can ticket out this fallback as tail work, since we’d have to think through the implications for roof:levels=* too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made some changes that require an imposm re-import, so I am considering to solve those issues in this PR: